Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Continued working on Shelf #16728

Merged
merged 13 commits into from
Mar 30, 2025

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Jan 22, 2025

Resolved / Related Issues

For #12490

This PR continues the work on the Shelf feature. The following are the requirements for this PR

  • Set IDataObject to only selected items
  • Spawn a menu flyout when dropping shelf items with options to copy or move items
  • (Optional for this PR) Add file system watcher for all items added to the shelf
  • (Optional for this PR) Persist shelf items across app startups

Steps used to test these changes

TBA

@Lamparter

This comment was marked as resolved.

@yaira2 yaira2 force-pushed the main branch 7 times, most recently from 30cea65 to decf3da Compare March 24, 2025 21:33
@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 25, 2025

Looks like there are some conflicts 👀

@yaira2 yaira2 changed the title More work on Shelf Code Quality: Continued working on Shelf Mar 28, 2025
@d2dyno1 d2dyno1 marked this pull request as ready for review March 30, 2025 10:32
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 30, 2025
@yaira2 yaira2 merged commit f9c9732 into files-community:main Mar 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants