Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality; Added global files to the solution file #16929

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Code Quality; Added global files to the solution file #16929

merged 2 commits into from
Mar 25, 2025

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 14, 2025 •
edited
Loading

Resolved / Related Issues

None

Steps used to test these changes

None

image

@0x5bfa
Update Files.slnx
21eb115 
Revert "Update Files.slnx"

This reverts commit 17758bb.

Update
@Lamparter
Copy link
Contributor

Lamparter commented Mar 14, 2025 •
edited
Loading

I don't like the name .solution
My reasoning for #16815 was that the files apply everywhere, and so should be in all the projects.
A better idea would be to put them in an appropriate build folder, e.g. eng/, but that would create a greater inconsistency with the actual file structure like platforms/ and core/ do (those folders don't actually exist)

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 16, 2025 •
edited
Loading

the goal here is not to match the folder structure but to keep developer experience the greatest possible. contrary, i dont encourage the team to have "core" and "platform" folders since they unnecessarily make nested structure and hide the projects inside. that said, theres still room to discuss the name of this virtual folder.

@yaira2 please review, @hez2010 based on your review before, is this good for you?

@yaira2 yaira2 force-pushed the main branch 7 times, most recently from 30cea65 to decf3da Compare March 24, 2025 21:33
@yaira2
Copy link
Member

yaira2 commented Mar 25, 2025

This looks good to me. Fyi @hez2010

@hez2010
Copy link
Member

hez2010 commented Mar 25, 2025

LGTM. While don't like the name ".solution" btw.
Maybe we can use some terms like "global" etc.?

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 25, 2025

LGTM. While don't like the name ".solution" btw. Maybe we can use some terms like "global" etc.?

The reason why I put the period . is to always put that folder at the very top. global is still bfore src and tests but we should keep in mind this. Let me change to it shortly.

hez2010
hez2010 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@hez2010 hez2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 25, 2025
@yaira2 yaira2 merged commit 40103fa into files-community:main Mar 25, 2025
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-Slnx branch March 25, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hez2010 hez2010

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x5bfa @Lamparter @yaira2 @hez2010