Integrate Latest @ 260187020

Changes to all ...
- Update Firebase Unity SDK to use Xcode 10.1 for building rather thanXcode 9.4.1, which is now deprecated by Apple and will be removed shortly.
Changes to dynamic_links/testapp ...
- Switch Dynamic Links to use Domain URI Prefix rather than Dynamic Links Domain, which is now marked as deprecated. This allows custom domains to be used.

CL: 260187020

Author: cynthiajiang

Diff for: analytics/testapp/readme.md

@@ -9,7 +9,7 @@ with the
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 9.4.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

Diff for: auth/testapp/Assets/Firebase/Sample/Auth/UIHandler.cs

@@ -113,9 +113,11 @@ protected virtual void Update() {
     }
 
     void OnDestroy() {
-      auth.StateChanged -= AuthStateChanged;
-      auth.IdTokenChanged -= IdTokenChanged;
-      auth = null;
+      if (auth != null) {
+        auth.StateChanged -= AuthStateChanged;
+        auth.IdTokenChanged -= IdTokenChanged;
+        auth = null;
+      }
       if (otherAuth != null) {
         otherAuth.StateChanged -= AuthStateChanged;
         otherAuth.IdTokenChanged -= IdTokenChanged;

Diff for: auth/testapp/readme.md

@@ -10,7 +10,7 @@ with the
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 9.4.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

Diff for: crashlytics/testapp/readme.md

@@ -9,7 +9,7 @@ inside the Unity Editor.
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher
-* [Xcode](https://developer.apple.com/xcode/) 9.4.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

Diff for: database/testapp/readme.md

@@ -9,7 +9,7 @@ inside the Unity Editor.
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 9.4.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

Diff for: dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandler.cs

@@ -34,19 +34,19 @@ public class UIHandler : MonoBehaviour {
     private string logText = "";
     const int kMaxLogSize = 16382;
     DependencyStatus dependencyStatus = DependencyStatus.UnavailableOther;
-    const string kInvalidDynamicLinksDomain = "THIS_IS_AN_INVALID_DOMAIN";
-    const string kDynamicLinksDomainInvalidError =
-      "kDynamicLinksDomain is not valid, link shortening will fail.\n" +
+    const string kInvalidDomainUriPrefix = "THIS_IS_AN_INVALID_DOMAIN";
+    const string kDomainUriPrefixInvalidError =
+      "kDomainUriPrefix is not valid, link shortening will fail.\n" +
       "To resolve this:\n" +
       "* Goto the Firebase console https://firebase.google.com/console/\n" +
       "* Click on the Dynamic Links tab\n" +
       "* Copy the domain e.g x20yz.app.goo.gl\n" +
-      "* Replace the value of kDynamicLinksDomain with the copied domain.\n";
+      "* Replace the value of kDomainUriPrefix with the copied domain.\n";
     public bool firebaseInitialized = false;
 
     // IMPORTANT: You need to set this to a valid domain from the Firebase
-    // console (see kDynamicLinksDomainInvalidError for the details).
-    public string kDynamicLinksDomain = "fwk68.app.goo.gl";
+    // console (see kDomainUriPrefixInvalidError for the details).
+    public string kDomainUriPrefix = "https://fwk68.app.goo.gl";
 
     // When the app starts, check to make sure that we have
     // the required dependencies to use Firebase, and if not,
@@ -126,7 +126,7 @@ DynamicLinkComponents CreateDynamicLinkComponents() {
         // The base Link.
         new System.Uri("https://google.com/abc"),
         // The dynamic link domain.
-        kDynamicLinksDomain) {
+        kDomainUriPrefix) {
         GoogleAnalyticsParameters = new Firebase.DynamicLinks.GoogleAnalyticsParameters() {
           Source = "mysource",
           Medium = "mymedium",
@@ -176,10 +176,10 @@ public Task<ShortDynamicLink> CreateAndDisplayUnguessableShortLinkAsync() {
     }
 
     private Task<ShortDynamicLink> CreateAndDisplayShortLinkAsync(DynamicLinkOptions options) {
-      if (kDynamicLinksDomain == kInvalidDynamicLinksDomain) {
-        DebugLog(kDynamicLinksDomainInvalidError);
+      if (kDomainUriPrefix == kInvalidDomainUriPrefix) {
+        DebugLog(kDomainUriPrefixInvalidError);
         var source = new TaskCompletionSource<ShortDynamicLink>();
-        source.TrySetException(new Exception(kDynamicLinksDomainInvalidError));
+        source.TrySetException(new Exception(kDomainUriPrefixInvalidError));
         return source.Task;
       }
 

Diff for: dynamic_links/testapp/readme.md

@@ -10,7 +10,7 @@ using the
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 9.4.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).
@@ -76,10 +76,13 @@ using the
       - In the `Player Settings` panel scroll down to `Bundle Identifier`
         and update the value to the package name you provided when you
         registered your app with Firebase.
-  - Copy the dynamic links domain for your project under the Dynamic Links
-    tab of the [Firebase console](https://firebase.google.com/console/)
-    e.g xyz.app.goo.gl and assign it to the string DynamicLinksDomain on
-    the UIHandler object in the MainScene.
+  - Copy the dynamic links domain URI prefix for your project under the Dynamic
+    Links tab of the [Firebase console](https://firebase.google.com/console/)
+    e.g xyz.app.goo.gl and assign it to the string DomainUriPrefix on the
+    UIHandler object in the MainScene.
+    - Optional: If you want to use a custom Dynamic Links domain, follow 
+      [these instructions](https://firebase.google.com/docs/dynamic-links/custom-domains)
+      to set up the domain in Firebase console and in your project's Info.plist.
   - Build for iOS
     - Select the `File > Build Settings` menu option.
     - Select `iOS` in the `Platform` list.
@@ -92,9 +95,9 @@ using the
       Google Sign-In to send invites).
       You can enable this capability on your project in Xcode 8 by going to
       your project's settings, Capabilities, and turning on Keychain Sharing.
-    - Copy the dynamic links domain for your project under the Dynamic Links
-      tab of the [Firebase console](https://firebase.google.com/console/)
-      Then, in your project's Capabilities tab:
+    - Copy the domain URI prefix for your project under the Dynamic Links tab of
+      the [Firebase console](https://firebase.google.com/console/) Then, in your
+      project's Capabilities tab:
       - Enable the Associated Domains capability.
       - Add applinks:YOUR_DYNAMIC_LINKS_DOMAIN
         For example "applinks:xyz.app.goo.gl".
@@ -170,10 +173,13 @@ using the
       - In the `Player Settings` panel scroll down to `Bundle Identifier`
         and update the value to the package name you provided when you
         registered your app with Firebase.
-  - Copy the dynamic links domain for your project under the Dynamic Links
-    tab of the [Firebase console](https://firebase.google.com/console/)
-    e.g xyz.app.goo.gl and assign it to the string DynamicLinksDomain on
-    the UIHandler object in the MainScene.
+  - Copy the dynamic links domain URI prefix for your project under the Dynamic
+    Links tab of the [Firebase console](https://firebase.google.com/console/)
+    e.g xyz.app.goo.gl and assign it to the string DomainUriPrefix on the
+    UIHandler object in the MainScene.
+    - Optional: If you want to use a custom Dynamic Links domain, follow
+      [these instructions](https://firebase.google.com/docs/dynamic-links/custom-domains)
+      to set up the domain in Firebase console.
   - Build for Android
     - Select the `File > Build Settings` menu option.
     - Select `Android` in the `Platform` list.

Diff for: functions/testapp/readme.md

@@ -9,7 +9,7 @@ inside the Unity Editor.
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 9.4.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

Diff for: messaging/testapp/readme.md

@@ -10,7 +10,7 @@ using the
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 9.4.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

Diff for: remote_config/testapp/readme.md

@@ -10,7 +10,7 @@ using the
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 9.4.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

Diff for: storage/testapp/readme.md

@@ -9,7 +9,7 @@ inside the Unity Editor.
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 9.4.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).