-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING steps #7960
Conversation
CONTRIBUTING.md
Outdated
* `X:\path\to\your\IDEA-U\ch-0\231.8109.175` (Windows after installed) | ||
6. Start the IntelliJ IDEA with the `flutter-intellij` project. | ||
|
||
2. [PLACHOLDER] Run [command?] to generate the `gradle.properties` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwren What is the command we need to run now that gradle.properties
is gitignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any of the ./bin/plugin commands work, many of them have a flag to specify which version. As we discussed yesterday, ideally, we would have a new command where all it does is update and create this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any of the ./bin/plugin commands work, many of them have a flag to specify which version. As we discussed yesterday, ideally, we would have a new command where all it does is update and create this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I just tried testing this by deleting gradle.properties
and running ./bin/plugin generate
but it didn't create it. I then first created gradle.properties
and ran ./bin/plugin generate
and it didn't populate it with anything.
Should I add instructions for manually creating a gradle.properties
file instead? At last until we have a command to create this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the time being, yes, include the gradle.properties that is currently working for you.
Fixes #7911