Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING steps #7960

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Conversation

elliette
Copy link
Member

@elliette elliette commented Mar 5, 2025

Fixes #7911

CONTRIBUTING.md Outdated
* `X:\path\to\your\IDEA-U\ch-0\231.8109.175` (Windows after installed)
6. Start the IntelliJ IDEA with the `flutter-intellij` project.

2. [PLACHOLDER] Run [command?] to generate the `gradle.properties` file.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwren What is the command we need to run now that gradle.properties is gitignored?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of the ./bin/plugin commands work, many of them have a flag to specify which version. As we discussed yesterday, ideally, we would have a new command where all it does is update and create this file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of the ./bin/plugin commands work, many of them have a flag to specify which version. As we discussed yesterday, ideally, we would have a new command where all it does is update and create this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I just tried testing this by deleting gradle.properties and running ./bin/plugin generate but it didn't create it. I then first created gradle.properties and ran ./bin/plugin generate and it didn't populate it with anything.

Should I add instructions for manually creating a gradle.properties file instead? At last until we have a command to create this file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the time being, yes, include the gradle.properties that is currently working for you.

@elliette elliette requested a review from jwren March 5, 2025 21:52
@elliette elliette merged commit 9a72135 into flutter:master Mar 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.md guide feedback
2 participants