Vulkan: RTE rounding for cpy to quant #12480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Vulkan
0cc4m
reviewed
Mar 20, 2025
|
The changes look good to me, but I haven't tested locally. |
|
I just tested these changes in sdcpp, LoRAs still load properly on quantized models, image quality (with LoRA) seemed slightly better with this PR compared to the current implementation, but that might just be luck or placebo effect. |
Co-Authored-By: Jeff Bolz <jbolz@nvidia.com>
RealTimeChris
pushed a commit
to RealTimeChris/llama.cpp
that referenced
this pull request
Mar 22, 2025
* Vulkan: RTE rounding for cpy to quant Co-Authored-By: Jeff Bolz <jbolz@nvidia.com> * remove trailing whitespace * avoid duplicating pipeline_cpy_f32_quant * fix copypasting issue * remove duplicated code --------- Co-Authored-By: Jeff Bolz <jbolz@nvidia.com>
Ivy233
pushed a commit
to Ivy233/llama.cpp
that referenced
this pull request
Mar 23, 2025
* Vulkan: RTE rounding for cpy to quant Co-Authored-By: Jeff Bolz <jbolz@nvidia.com> * remove trailing whitespace * avoid duplicating pipeline_cpy_f32_quant * fix copypasting issue * remove duplicated code --------- Co-authored-by: Jeff Bolz <jbolz@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some failing tests
Discussed here: #11166
@jeffbolznv