Skip to content

Commit 1867fe4

Browse files
authored
Reverse conditional checker (#729)
1 parent ced86f2 commit 1867fe4

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Diff for: CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# Upcoming
2+
* Android Resolver - Reverse conditional checker for `packaging` keyword in maintemplate based on android gradle plugin version. Fixes #715
3+
14
# Version 1.2.184 - Jan 28, 2025
25
* Android Resolver - Update and resolve `packaging` keyword in maintemplate
36
based on android gradle plugin version.

Diff for: source/AndroidResolver/src/PlayServicesResolver.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -2354,7 +2354,7 @@ internal static IList<string> PackagingOptionsLines(ICollection<Dependency> depe
23542354
lines.Add("android {");
23552355

23562356
// `packagingOptions` is replaced by `packaging` keyword in Android Gradle plugin 8.0+
2357-
if ((new Dependency.VersionComparer()).Compare("8.0", AndroidGradlePluginVersion) <= 0) {
2357+
if ((new Dependency.VersionComparer()).Compare("8.0", AndroidGradlePluginVersion) >= 0) {
23582358
lines.Add(" packaging {");
23592359
} else {
23602360
lines.Add(" packagingOptions {");

0 commit comments

Comments
 (0)