Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling cleanup #995

Open
sugarmanz opened this issue Feb 27, 2020 · 1 comment
Open

Better error handling cleanup #995

sugarmanz opened this issue Feb 27, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@sugarmanz
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When auto fails, it should revert/cleanup any changes or commits it made.

Ex: when I have uncommitted changes and run auto, it will create a CHANGELOG commit, but then fail out when it detects the issue. Unfortunately, the CHANGELOG commit stays around.

Describe the solution you'd like

Plugins should tap into a cleanup hook to provide functionality to revert any changes it made.

Describe alternatives you've considered

Potentially, auto core could do all the cleanup, but that would be difficult depending on the different functionality of plugins.

@sugarmanz sugarmanz added the enhancement New feature or request label Feb 27, 2020
@hipstersmoothie
Copy link
Collaborator

One part of this will be removing process.exit from any plugin or core. They should just throw an error that we catch in the cli and exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants