Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature-8.6
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 57 files changed
  • 5 contributors

Commits on Mar 19, 2025

  1. feat(datetime): add showAdjacentDays to display days from the previou…

    …s and next months (#30262)
    
    Issue number: Internal
    
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    Adds a new property to datetime, showAdjacentDays, that when true will
    show the last days of the previous month and the first days of the next
    month. This will just occupy empty "cells" at the beginning of the month
    "table" and add rows to the table until a maximum of 6 rows are
    displayed.
    
    ## Changes
    - add styles for adjacent day button
    - add `showAdjacentDays` property to datetime component
    - change month generation to respect new property
    - add visual tests to new feature
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    ## Other information
    
    
    [Preview](https://ionic-framework-git-rou-11118v2-ionic1.vercel.app/src/components/datetime/test/show-adjacent-days)
    
    ---------
    
    Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
    Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
    Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
    4 people authored Mar 19, 2025
    Copy the full SHA
    b67259e View commit details

Commits on Mar 28, 2025

  1. feat(datetime): add animation to adjacent days selection (#30298)

    Issue number: internal
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    Now when an adjacent day is selected the component will scroll to the
    pretended month, as it does when a month change via arrow buttons.
    
    ## Changes:
    - add styles for active adjacent day;
    - scroll animation when adjacentDay is selected;
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    - [md
    preview](https://ionic-framework-git-rou-11744-ionic1.vercel.app/src/components/datetime/test/show-adjacent-days?ionic:mode=md)
    - [ios
    preview](https://ionic-framework-git-rou-11744-ionic1.vercel.app/src/components/datetime/test/show-adjacent-days?ionic:mode=ios
    )
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    ---------
    
    Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
    Co-authored-by: ionitron <hi@ionicframework.com>
    3 people authored Mar 28, 2025
    Copy the full SHA
    e140b90 View commit details

Commits on Mar 31, 2025

  1. Copy the full SHA
    78df64c View commit details
  2. Copy the full SHA
    e27bb2c View commit details
  3. Copy the full SHA
    91477cf View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff main...feature-8.6