feat(checkbox): add helper and error text to the ionic theme #30278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
force-pushed
the
FW-6389-checkbox
branch
from
8ba4ea9 to
7aac2db
Compare
brandyscarney
commented
Mar 20, 2025
| @@ -297,15 +179,6 @@ input { | |||
| max-width: calc(100% / 0.75); | |||
| } | |||
|
|
|||
| // TODO(ROU-10796): uncomment this when the scss compilation issue is fixed | |||
There was a problem hiding this comment.
Removing this should close ROU-10796
brandyscarney
commented
Mar 20, 2025
There was a problem hiding this comment.
This is how ios and md look so I assume we want the same here
BenOsodrac
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
Does this introduce a breaking change?
Other information
Preview