Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(textarea): use proper design for helper and error text #30283

Merged
merged 13 commits into from
Mar 25, 2025
Merged

fix(textarea): use proper design for helper and error text #30283

merged 13 commits into from
Mar 25, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Mar 20, 2025 •
edited
Loading

Issue number: internal

What is the new behavior?

  • Updates the common and native stylesheets to separate the bottom content styles
  • Fixes an improperly updated counter text color for native
  • Adds missing styles for valid/invalid states and screenshot tests for the highlight

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 3:22pm

@github-actions github-actions bot added the package: core @ionic/core package label Mar 20, 2025
brandyscarney
brandyscarney commented Mar 20, 2025
View reviewed changes
...extarea.e2e.ts-snapshots/textarea-fill-outline-label-floating-md-ltr-Mobile-Chrome-linux.png Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the counter text color to match main. It was undone when next was updated from main.

@brandyscarney brandyscarney marked this pull request as ready for review March 20, 2025 20:14
@brandyscarney brandyscarney requested a review from a team as a code owner March 20, 2025 20:14
thetaPC
thetaPC approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with non-blocking questions

thetaPC
thetaPC approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit b57d432 into next Mar 25, 2025
48 checks passed
@brandyscarney brandyscarney deleted the FW-6389-textarea branch March 25, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC

@BenOsodrac BenOsodrac

@christian-bromann christian-bromann

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandyscarney @thetaPC @BenOsodrac