Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite should better support 1.0 libraries. #489

Closed
davidlehn opened this issue May 16, 2017 · 1 comment
Closed

Test suite should better support 1.0 libraries. #489

davidlehn opened this issue May 16, 2017 · 1 comment
Assignees

Comments

@davidlehn
Copy link
Member

The test suite currently mixes 1.0 and 1.1 tests. It is difficult to use the test suite with 1.0 libs that have not yet updated to 1.1 support. There is a "processingMode" option that can be set to json-ld-1.0 or json-ld-1.1 but in some cases this is set to 1.0 on purpose to test 1.1 features (see tp002 and tp005 in https://github.com/json-ld/json-ld.org/blob/master/test-suite/tests/error-manifest.jsonld). This issue might be resolved with more explicit marking of 1.1 tests separate from the processing mode.

One option might be to add a "version" option for all 1.1 tests so a 1.0 lib could skip all 1.1 tests via a simple filter. The current "processingMode" would more directly map to the API option of the same name and could perhaps default to the version unless explicitly set otherwise.

See also:
digitalbazaar/jsonld.js#172
digitalbazaar/jsonld.js#179
7374dff#commitcomment-21885156

@gkellogg
Copy link
Member

The processingMode entry has specific meaning for the API, and using version might be confusing in a test manifest entry, as it looks like the context @version. Suggest using specVersion; when not set, it is presumed to be valid for either 1.0 or 1.1 testing. Otherwise, it determines the spec-version being tested.

There are probably some cases where a 1.1 processor will get different results than a 1.0 processor, so may need modes like the following:

  • 1.0 only
  • 1.1 only
  • 1.0+ (maybe use "1.x")

Values probably need to be strings to allow for variations such as 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants