Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAE-1872] Endpoint resource optimisation #197

Open
wants to merge 137 commits into
base: release/8.0.0
Choose a base branch
from

Conversation

renczesstefan
Copy link
Member

@renczesstefan renczesstefan commented May 16, 2023

Description

Optimised endpoint data, corrected tests to V7, merged with 6.3.0

Implements NAE-1872

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

There are no dependencies on other PR.

How Has Been This Tested?

This was tested manually with postman, JProfiler and unit tests.

Test Configuration

Name Tested on
OS macOS Ventura 13.1
Runtime Node 14.19.3
Dependency Manager NPM 6.14.17
Framework version Angular 13.3.1
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @mazarijuraj
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

minop and others added 30 commits September 7, 2022 12:59
- Empty Task ref component classes
- Don't filter out dashboard task ref fields when preprocessing data groups
- associate dashboard tiles with dashboard task ref field
- component resolver task ref field
- resolve dashboard rows/cols
- fix resolve dashboard rows/cols
- layout task ref dashboard grid tiles
- fix dashboard group title line present
- fix dashboard group lost layout information
- task ref dashboard tile content resolution
- fix task ref dashboard tile task content spinner
- task ref dashboard tile + button
- create task ref dashboard tile case on +
- task ref dashboard tile + is shown only if the task ref is editable and not blocked (assigned)
- create new task ref dashboard tile case instance and set relevant tile data
- set new task ref dashboard tile reference in the parent task ref
- fixed diagonal swap of dashboard + button positions
- change button type
- add border
- hidden fields in data groups are filtered only in the data groups that are immediately displayed (dashboard content is passed unfiltered until it reaches the display stage)
- dashboard line chart text field component prototype/example
- display the chart component as a text area when editable
- fix empty dashboard bugs
- add parent case id data when creating dashboard tile
- add portal card component
- add portal component registry service
- add iframe dashboard component
- register multiple example app components to dashboard registry
- add injector as component getter argument
- refresh content of task, when new tile is added by clicking +
machacjozef and others added 16 commits May 4, 2023 17:46
# Conflicts:
#	CHANGELOG.md
#	package.json
#	projects/nae-example-app/src/app/app.module.ts
#	projects/netgrif-components-core/package.json
#	projects/netgrif-components/package.json
#	projects/netgrif-components/src/lib/data-fields/data-fields.module.ts
#	projects/netgrif-components/src/lib/panel/panel.module.ts
- corrected dashboard error
# Conflicts:
#	CHANGELOG.md
#	package.json
#	projects/netgrif-components-core/package.json
#	projects/netgrif-components/package.json
# Conflicts:
#	package.json
#	projects/netgrif-components-core/package.json
#	projects/netgrif-components/package.json
- removed node 12 support
- modified CHANGELOG.md
[NAE-1881] Release 6.3.0-rc.9
- modified enums
- modified resources according to BE
# Conflicts:
#	projects/netgrif-components-core/src/lib/task-content/services/field-converter.service.ts
@renczesstefan renczesstefan added improvement New feature or request breaking change Fix or feature that would cause existing functionality doesn't work as expected Extra Large Large upgrade labels May 16, 2023
@renczesstefan renczesstefan self-assigned this May 16, 2023
@pull-request-quantifier-deprecated

This PR has 7455 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +5343 -2112
Percentile : 100%

Total files changed: 743

Change summary by file extension:
.yml : +1 -1
.md : +16 -2
.html : +1773 -1506
.json : +16 -10
.ts : +3359 -592
.scss : +178 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

47.2% 47.2% Coverage
1.2% 1.2% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Fix or feature that would cause existing functionality doesn't work as expected Extra Large improvement New feature or request upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants