This repository was archived by the owner on Feb 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Port Sqplus to sqrat #5
Open
bluehazzard
wants to merge
16
commits into
obfuscated:master
Choose a base branch
from
bluehazzard:sqrat_pull_req_1-A
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update squirrel from 2.2.5 to 3.0.4 stable does not update project files will not compile
Remove the sqplus binding library does not update project files will not compile
Add the new sqrat binding library does not update project files will not compile
…it possible to compile files and catch errors from sqrat and squirrel. There is also a api for sand boxing a vm for temporary handling.
…at (1/3) - remove all wx related stuff from cb squirrel files + Add ClearPlugins() function to clean up all registered Plugins * All register functions expect a vm parameter to make it possible to * register to different vms
…at (2/3) * port c::b internal functions binding to sqrat
* move all wxWidgets related files to sq_wx subfolder * split the string handling in a separate source file * script binding register methods expect a vm parameter so multiple vms can be used + add wxString handler to the sqrat api, to make a automated conversation between squirrel strings and wxStrings (in any direction) + add "_tostring" methods for all wx types + add unicode support for wxString class (only UTF8) + add ToInt and ToDouble to wxString + add "wxT()" + add wxColour(int,int,int) constructor + add wxPoint::Cmp() + add wxSize::Cmp() + add wxStopWatch * move all wxWidgets const to the const table
… for console output (errors in red)
* Squirrel errors get reported in a seperate dialog and in the cb log output. Included is a stack trace and the local variables from the top function call
API change: ReplaceMacros has now a parameter to describe the name in what context it is called. This is used for error reporting for the scripting engine. Parameter has default value so no code rework is needed
Encapsulate the plugin script binding in a namespace (=table with the name "Abbreviations") to avoid name collisions, specially with the Function "AutoComplete". To access this function call Abbreviations.AutoComplete()
private: | ||
// needed for SqPlus bindings | ||
ScriptingManager(cb_unused const ScriptingManager& rhs); // prevent copy construction | ||
|
||
void OnScriptMenu(wxCommandEvent& event); | ||
void OnScriptPluginMenu(wxCommandEvent& event); | ||
void RegisterScriptFunctions(); | ||
void OnDebugTimer(wxTimerEvent& event); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is without functionality at the moment and can be removed...
void OnDebugTimer(wxTimerEvent& event);
wxTimer m_DebugerUpdateTimer;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the port from sqplus to sqrat
The [NOT COMPILE] marked commits do not compiler, because the project files are not updated until 77c1e3e . I have split up the commits to make the changes more clear.
Motivation for the port
Changes
SDK Api
All changes to the api affect only scripting related things... So if a plugin does not use scripting no changes to the code are needed.
Scripting changes
General
wxWidgets related
cb binding related
User experience
Help needed
Todo
old bugs
The "bugs" listed here are present in the sqplus AND in the sqrat implementation.
improvements in the pipeline
...