Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Logout user scenario #67

Closed
wants to merge 1 commit into from
Closed

Conversation

Lemeri123
Copy link

This pull request introduces the UserLogoutScenario class, which is designed to simulate the user logout process in the OpenMRS performance testing suite. The scenario ensures that the logout functionality is contributing to the overall robustness and reliability of the system.

Additionally:
Added a logoutRequest method so that the UserLogoutScenario can correctly reference the logoutRequest method.

@Lemeri123
Copy link
Author

@jayasanka-sack please look through this and let me know if am on the right track

@Bawanthathilan
Copy link
Collaborator

@jayasanka-sack please look through this and let me know if am on the right track

Hi @Lemeri123 , Your PR is basically adding a logout user scenario. But why create a new scenario when we already have existing ones? Scenarios represent real-world actions performed by personas in the system—like a doctor going to the hospital, logging into the system, opening a chart page, and starting a visit.

However, your change introduces a new scenario where the doctor goes to the hospital just to trigger a system logout, which doesn’t quite fit. Also, logout itself isn’t typically considered part of a scenario.

@jayasanka-sack
Copy link
Member

Thanks for your PR @Lemeri123! As @Bawanthathilan mentioned, a scenario in load testing represents a sequence of real-world user interactions rather than a single action. Users don’t typically go to a system just to log out, so this doesn’t align with how scenarios are structured.

We intentionally did not include logout in our existing scenarios because, in real-world usage, most users don’t explicitly log out from the system.

I’ll go ahead and close this PR, but we appreciate the effort! ❤️
Feel free to contribute to other areas where improvements are needed. Thanks again!

@Lemeri123
Copy link
Author

Ohhh @Bawanthathilan, @jayasanka-sack thanks for the guidance

@Lemeri123 Lemeri123 deleted the UserLogout branch February 25, 2025 17:41
@Lemeri123
Copy link
Author

Ohhhh by the way @jayasanka-sack, @Bawanthathilan can an appointment booking scenario be a valid scenario?? or the existing scenarios are all we need?????

@jayasanka-sack
Copy link
Member

That’s a valid scenario. Could you please draft a Google Doc with the steps and all the API calls involved? Once we verify everything, you can start implementing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants