Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-4521 : Add program tab to the visit patient scenario #77

Merged
merged 7 commits into from
Mar 15, 2025

Conversation

dilankavishka
Copy link
Contributor

This pull request introduces the following changes to Add Programs Tab in Visit Patient scenario:

Ticket URL: https://openmrs.atlassian.net/browse/O3-4521

@dilankavishka
Copy link
Contributor Author

@jayasanka-sack @Bawanthathilan Could you review this please?

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @dilankavishka! This is a valid step that we can include to the scenario.

@Bawanthathilan, I'll leave it to you to make sure we've covered all the necessary API calls. Let us know when you're happy with it!

@Bawanthathilan
Copy link
Collaborator

Great work, @dilankavishka! This is a valid step that we can include to the scenario.

@Bawanthathilan, I'll leave it to you to make sure we've covered all the necessary API calls. Let us know when you're happy with it!

Great work, @dilankavishka! This is a valid step that we can include to the scenario.

@Bawanthathilan, I'll leave it to you to make sure we've covered all the necessary API calls. Let us know when you're happy with it!

@dilankavishka I think there's another API endpoint call for opening the program tab. Currently, you are only calling this endpoint:

https://dev3.openmrs.org/openmrs/ws/rest/v1/program

but there is another endpoint being called:

https://dev3.openmrs.org/openmrs/ws/rest/v1/programenrollment

Can you check and update the PR accordingly?
Screenshot 2025-03-11 at 8 13 51 PM

@dilankavishka
Copy link
Contributor Author

@Bawanthathilan I update the file with the other end point. could you please take a look now?

@Bawanthathilan
Copy link
Collaborator

@Bawanthathilan I update the file with the other end point. could you please take a look now?

Thanks @dilankavishka. Please resolve the conflicts.

@Bawanthathilan
Copy link
Collaborator

Thanks @dilankavishka 👏

@Bawanthathilan Bawanthathilan merged commit c4f3cf6 into openmrs:main Mar 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants