O3-4527: Add an attachment in Visit Patient Scenario #79
Conversation
|
@jayasanka-sack @Bawanthathilan Could you review this please? |
There was a problem hiding this comment.
Thanks For the PR @UNCANNY69 . Please check my comments bellow:
src/test/resources/TestImage.png
Outdated
There was a problem hiding this comment.
Please use a realistic file-sized image. You can download one from here, rename it, and upload it.
There was a problem hiding this comment.
Yep, I'd prefer a 1MB one to make it more realistic with the file size. Rename it to "Sample 1MB image.jpg" or something to highlight the file size.
There was a problem hiding this comment.
Addressed the changes
There was a problem hiding this comment.
Please use a realistic file-sized image. You can download one from here, rename it, and upload it.
@UNCANNY69 check this
src/test/resources/TestImage.png
Outdated
There was a problem hiding this comment.
Please remove the previous image.
There was a problem hiding this comment.
Resolved it, thanks a lot @Bawanthathilan for the review :)
There was a problem hiding this comment.
This image is around 3.4KB. Can we upload one that's around 1MB? It’s better to upload an image of around 1MB. Please check the previous comments we posted
There was a problem hiding this comment.
Sure @Bawanthathilan i had a misunderstanding , sorry for the inconvenience. I have updated the PR
|
Thanks for getting this done @UNCANNY69 🚀 |
Extended the Visit Patient Scenario to allow adding of attachments within the scenario.
JIRA LINK: https://openmrs.atlassian.net/browse/O3-4527