Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-4527: Add an attachment in Visit Patient Scenario #79

Merged
merged 5 commits into from
Mar 13, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deleting the previous image
  • Loading branch information
UNCANNY69 committed Mar 13, 2025
commit 4ba5f999065c203599f61f8b7972096ea70ee0f7
Binary file removed src/test/resources/TestImage.png
Copy link
Collaborator

@Bawanthathilan Bawanthathilan Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a realistic file-sized image. You can download one from here, rename it, and upload it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'd prefer a 1MB one to make it more realistic with the file size. Rename it to "Sample 1MB image.jpg" or something to highlight the file size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the changes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a realistic file-sized image. You can download one from here, rename it, and upload it.

@UNCANNY69 check this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the previous image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved it, thanks a lot @Bawanthathilan for the review :)

Binary file not shown.