-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "conceptMappings" from dummy form schema #130
Comments
@mogoodrich Assuming support for "concept mappings" is a priority for orgs like PIH for an MVP, I'm inclined to keep them considering that we may introduce this support very soon. |
@samuelmale for concept mapping support, we'd want to be able to unqiuely reference a concept by mapping and source instead of uuid, so I think we'd want to use the concept field for this, ie support:
We could consider using a mapping field instead of a concept field, like:
But I don't see a case where we'd want to ever specify multiple mappings or use an array. |
Makes perfect sense @mogoodrich! |
@samuelmale are you tracking this issue and working on it? |
No @hadijahkyampeire, I'm not. Feel free to take it up. |
The dummy schema from provided by the form builder includes "conceptMapping" fields, ie:
These "conceptMappings" fields are currently ignored (and probably always will be) so we should remove them from the dummy schema to avoid confusion.
fyi @denniskigen @samuelmale
The text was updated successfully, but these errors were encountered: