Skip to content

Commit 6c8afd5

Browse files
Muppasanipraneethdenniskigen
authored andcommittedMar 17, 2025
fix: Update delete identifier modal to use closeModal function instead of deleteIdentifier for cancel action
1 parent c78bab3 commit 6c8afd5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed
 

‎packages/esm-patient-registration-app/src/widgets/delete-identifier-confirmation.modal.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const DeleteIdentifierConfirmationModal: React.FC<DeleteIdentifierConfirmationMo
3636
</p>
3737
</ModalBody>
3838
<ModalFooter>
39-
<Button kind="secondary" size="lg" onClick={() => deleteIdentifier(false)}>
39+
<Button kind="secondary" size="lg" onClick={closeModal}>
4040
{t('cancel', 'Cancel')}
4141
</Button>
4242
<Button kind="danger" size="lg" onClick={() => deleteIdentifier(true)}>

‎packages/esm-patient-registration-app/src/widgets/delete-identifier-confirmation.test.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import DeleteIdentifierConfirmationModal from './delete-identifier-confirmation.
55

66
describe('DeleteIdentifierConfirmationModal', () => {
77
const mockDeleteIdentifier = jest.fn();
8+
const closeModal = jest.fn();
89
const mockIdentifierName = 'Identifier Name';
910
const mockIdentifierValue = 'Identifier Value';
1011

@@ -13,7 +14,7 @@ describe('DeleteIdentifierConfirmationModal', () => {
1314

1415
render(
1516
<DeleteIdentifierConfirmationModal
16-
closeModal={jest.fn()}
17+
closeModal={closeModal}
1718
deleteIdentifier={mockDeleteIdentifier}
1819
identifierName={mockIdentifierName}
1920
identifierValue={mockIdentifierValue}
@@ -22,7 +23,7 @@ describe('DeleteIdentifierConfirmationModal', () => {
2223

2324
const cancelButton = screen.getByRole('button', { name: /cancel/i });
2425
await user.click(cancelButton);
25-
expect(mockDeleteIdentifier).toHaveBeenCalledWith(false);
26+
expect(closeModal).toHaveBeenCalledTimes(1);
2627

2728
const removeButton = screen.getByRole('button', { name: /remove identifier/i });
2829
await user.click(removeButton);

0 commit comments

Comments
 (0)
Failed to load comments.