MF-634: Fix design issues in the patient search #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes include: - Correct the fill color of the clipboard svg shown when there are no matching search results. - Amend patient search results count text to match the new designs (also, add a bottom border). - Fix spacing on the empty search results view. - Change cursor style to `pointer` when hovering over search results. - Change color of pagination controls to match the navbar on click and on hover. - Change color of the search input when focused to `crusta (#ff832b)`.
|
Update: Looks like Sean has been tasked with working on Tablet search vs Desktop search. Neat. |
denniskigen
added a commit
that referenced
this pull request
Jun 22, 2021
Fixes that should have been part of [MF-634](#10): - Fix two invalid CSS rules. - Delete unused stylesheet.
Merged
CynthiaKamau
added a commit
to CynthiaKamau/openmrs-esm-patient-management
that referenced
this pull request
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes include:
pointerwhen hovering over search results.crusta (#ff832b).Note that this PR does not represent all of the required changes as indicated in the document. Subsequent PRs will look into the possibility of reusing the patient banner extension to display patient cards in the search results. I seem to recall Eudson working on something similar. Work on amending the UI to suit both the desktop and tablet designs will be packaged in a forthcoming PR.
Linked PR with Carbon pagination style overrides: openmrs/openmrs-esm-core#133