Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add sidenav to outpatient dashboard #147

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

samuelmale
Copy link
Member

@samuelmale samuelmale commented Apr 1, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Adds sidebar navigation

Screenshots

2022-04-01 08-30-16 2022-04-01 08_33_19

Related Issue

Other

None.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

File size impact

Merging O3-1122 into main impact files as follow:

@openmrs/esm-active-visits-app (+2.39%)
Files new size
packages/esm-active-visits-app/dist/403.js 142 kB 👶
packages/esm-active-visits-app/dist/547.js 42.2 kB 👶
packages/esm-active-visits-app/dist/339.js 423 kB (+30 kB / +7.63%) ↗️
packages/esm-active-visits-app/dist/373.js 16.9 kB (+101 B / +0.6%) ↗️
packages/esm-active-visits-app/dist/932.js 19.3 kB (+101 B / +0.52%) ↗️
packages/esm-active-visits-app/dist/879.js 6.54 kB (+77 B / +1.19%) ↗️
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 9.13 kB (+4 B / +0.04%) ↗️
packages/esm-active-visits-app/dist/745.js 1.46 kB (+2 B / +0.14%) ↗️
packages/esm-active-visits-app/dist/260.js 28.3 kB (-107 B / -0.38%) ↘️
packages/esm-active-visits-app/dist/55.js deleted (-41.1 kB)
packages/esm-active-visits-app/dist/969.js deleted (-142 kB)
packages/esm-active-visits-app/dist/313.js 82 kB (0 B / +0%) 👻
packages/esm-active-visits-app/dist/382.js 88.4 kB (0 B / +0%) 👻
Unmodified (6) 452 kB (0 B / +0%) 👻
Total (19) 1.31 MB (+30.6 kB / +2.39%) ↗️
@openmrs/esm-outpatient-app (+250.28%)
Files new size
packages/esm-outpatient-app/dist/940.js 3.87 MB 👶
packages/esm-outpatient-app/dist/721.js 1.13 MB 👶
packages/esm-outpatient-app/dist/613.js 827 kB 👶
packages/esm-outpatient-app/dist/34.js 456 kB 👶
packages/esm-outpatient-app/dist/238.js 321 kB 👶
packages/esm-outpatient-app/dist/654.js 189 kB 👶
packages/esm-outpatient-app/dist/956.js 123 kB 👶
packages/esm-outpatient-app/dist/564.js 42.8 kB 👶
packages/esm-outpatient-app/dist/339.js 423 kB (+30 kB / +7.63%) ↗️
packages/esm-outpatient-app/dist/986.js 24.4 kB 👶
packages/esm-outpatient-app/dist/373.js 18.8 kB 👶
packages/esm-outpatient-app/dist/700.js 3.6 kB 👶
packages/esm-outpatient-app/dist/634.js 2.25 kB 👶
packages/esm-outpatient-app/dist/635.js 233 kB (+1.65 kB / +0.71%) ↗️
packages/esm-outpatient-app/dist/openmrs-esm-outpatient-app.js 9.85 kB (+993 B / +11.21%) ↗️
packages/esm-outpatient-app/dist/817.js 25.6 kB (+139 B / +0.55%) ↗️
packages/esm-outpatient-app/dist/932.js 19.4 kB (+105 B / +0.54%) ↗️
packages/esm-outpatient-app/dist/233.js 386 B (-98 B / -20.25%) ↘️
packages/esm-outpatient-app/dist/745.js deleted (-1.32 kB)
packages/esm-outpatient-app/dist/594.js deleted (-1.79 kB)
packages/esm-outpatient-app/dist/446.js deleted (-3.74 kB)
packages/esm-outpatient-app/dist/45.js deleted (-523 kB)
packages/esm-outpatient-app/dist/134.js deleted (-924 kB)
Unmodified (4) 97.1 kB (0 B / +0%) 👻
Total (27) 7.81 MB (+5.58 MB / +250.28%) ↗️
@openmrs/esm-patient-list-app (+1.84%)
Files new size
packages/esm-patient-list-app/dist/279.js 215 kB 👶
packages/esm-patient-list-app/dist/934.js 75.7 kB 👶
packages/esm-patient-list-app/dist/122.js 423 kB (+30 kB / +7.63%) ↗️
packages/esm-patient-list-app/dist/290.js 16.7 kB 👶
packages/esm-patient-list-app/dist/932.js 19.4 kB (+101 B / +0.52%) ↗️
packages/esm-patient-list-app/dist/601.js 19.2 kB (+91 B / +0.48%) ↗️
packages/esm-patient-list-app/dist/747.js 69.3 kB (+50 B / +0.07%) ↗️
packages/esm-patient-list-app/dist/openmrs-esm-patient-list-app.js 10.9 kB (+13 B / +0.12%) ↗️
packages/esm-patient-list-app/dist/260.js 3.26 kB (+10 B / +0.31%) ↗️
packages/esm-patient-list-app/dist/37.js 190 kB (+2 B / +0%) ↗️
packages/esm-patient-list-app/dist/61.js 12 kB (+2 B / +0.02%) ↗️
packages/esm-patient-list-app/dist/73.js deleted (-13.6 kB)
packages/esm-patient-list-app/dist/648.js deleted (-77.5 kB)
packages/esm-patient-list-app/dist/64.js deleted (-217 kB)
packages/esm-patient-list-app/dist/330.js 32.5 kB (0 B / +0%) 👻
packages/esm-patient-list-app/dist/851.js 5.69 kB (0 B / +0%) 👻
Unmodified (14) 590 kB (0 B / +0%) 👻
Total (30) 1.68 MB (+30.4 kB / +1.84%) ↗️
@openmrs/esm-patient-registration-app (+1.94%)
Files new size
packages/esm-patient-registration-app/dist/592.js 291 kB 👶
packages/esm-patient-registration-app/dist/339.js 423 kB (+30 kB / +7.63%) ↗️
packages/esm-patient-registration-app/dist/932.js 19.4 kB (+101 B / +0.52%) ↗️
packages/esm-patient-registration-app/dist/450.js 3.18 kB (+2 B / +0.06%) ↗️
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 22.3 kB (+2 B / +0.01%) ↗️
packages/esm-patient-registration-app/dist/71.js 14.8 kB (+1 B / +0.01%) ↗️
packages/esm-patient-registration-app/dist/16.js 320 kB (-1 B / -0%) ↘️
packages/esm-patient-registration-app/dist/844.js deleted (-290 kB)
Unmodified (14) 533 kB (0 B / +0%) 👻
Total (22) 1.63 MB (+31 kB / +1.94%) ↗️
@openmrs/esm-patient-search-app (+2.99%)
Files new size
packages/esm-patient-search-app/dist/856.js 74.2 kB 👶
packages/esm-patient-search-app/dist/339.js 423 kB (+30 kB / +7.63%) ↗️
packages/esm-patient-search-app/dist/373.js 16.9 kB (+101 B / +0.6%) ↗️
packages/esm-patient-search-app/dist/932.js 19.3 kB (+101 B / +0.52%) ↗️
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 8.65 kB (+2 B / +0.02%) ↗️
packages/esm-patient-search-app/dist/745.js 1.42 kB (+1 B / +0.07%) ↗️
packages/esm-patient-search-app/dist/852.js deleted (-74 kB)
packages/esm-patient-search-app/dist/893.js 174 kB (0 B / +0%) 👻
Unmodified (5) 329 kB (0 B / +0%) 👻
Total (13) 1.05 MB (+30.4 kB / +2.99%) ↗️
Generated by @jsenv/file-size-impact during Report bundle size#2088343638 on c6c174f

@jonathandick jonathandick requested a review from brandones April 1, 2022 19:42
Copy link
Contributor

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! By which I mean, it looks like the code I wrote 😆 Which is great, because that means this will be easy to refactor. Thanks for doing this @samuelmale .

Just one change needed, looks like you left some debug code in.

@brandones brandones merged commit 9d653f7 into openmrs:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants