Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3 4541 : Fix identifier deletion modal handling in registration form #1528

Merged
merged 3 commits into from
Mar 17, 2025
Merged

(fix) O3 4541 : Fix identifier deletion modal handling in registration form #1528

merged 3 commits into from
Mar 17, 2025
+16 −13

Conversation

Muppasanipraneeth
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • currently while Removing the identifier when we click on delete icon . modal pops and if we want close the modal on clicking close icon its not closing
  • so fixed it

Screenshots

Before

Screen.Recording.2025-03-17.at.7.26.10.PM.mov

screenshot

Screenshot 2025-03-17 at 7 51 34 PM

After

Screen.Recording.2025-03-17.at.7.21.34.PM.mov

screen shot

Screenshot 2025-03-17 at 7 27 36 PM

Related Issue

jira ticket link

Other

@Muppasanipraneeth
Copy link
Contributor Author

@denniskigen can you review this

denniskigen
denniskigen approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@denniskigen denniskigen changed the title (fix) O3 4541 : Fix Modal Close Issue on Identifier Removal in Patient Edit (fix) O3 4541 : Fix identifier deletion modal handling in registration form Mar 17, 2025
@denniskigen denniskigen merged commit e17f180 into openmrs:main Mar 17, 2025
6 checks passed
@Muppasanipraneeth Muppasanipraneeth deleted the O3-4541 branch March 18, 2025 01:47
@Muppasanipraneeth
Copy link
Contributor Author

Thanks @denniskigen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Muppasanipraneeth @denniskigen