Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-641: Patient List Modal #22

Closed

Conversation

vasharma05
Copy link
Member

What does this PR do?

This PR comprises of various components:

  1. Modal Design
  2. Fetching patient lists
  3. Review changes (reviews given to Deploy patient list #19 )
  4. Implementing search for patient lists.

Design: https://app.zeplin.io/project/60d59321e8100b0324762e05/screen/60d5993c822cc112375b4379

@@ -84,33 +91,27 @@ export async function getPatientListsForPatient(patientUuid: string) {
}: {
results: Array<OpenmrsCohortMember>;
error: Error;
} = await (await fetch(`/openmrs/ws/rest/v1/cohortm/cohortmember?patient=${patientUuid}&v=default`)).json();
} = await (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await await?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the data is already resolved - no need for the outer await)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll remove the outer one.

@FlorianRappl FlorianRappl deleted the branch openmrs:deploy_patient_list July 16, 2021 21:15
@FlorianRappl FlorianRappl mentioned this pull request Jul 16, 2021
CynthiaKamau pushed a commit to CynthiaKamau/openmrs-esm-patient-management that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants