-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MF-641: Completed Patient List Modal #26
Conversation
www_screencapture_com_2021-7-27_13_56.mp4Correction: screen width -> screen height @FlorianRappl @jonathandick I have tried to show the modal and the workflow too. @FlorianRappl this video also contains the workflow, which I want you to go through, it will help in solving out the queries you pointed above and can you please suggest me something better, if this workflow doesn't look good to you. @jonathandick I want you to please check the text shown in the toasts and direct if any changes are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already suggested something better.
- Remove the global
closeModal
. - Remove the
openModal
. - Call
showModal
directly in theAddPastVisitOverflowMenuItem
component:
const openModal = React.useCallback(() => {
const dispose = showModal('add-patient-to-patient-list-modal', {
close: () => dispose();
});
}, []);
Thanks @FlorianRappl ! I didn't think of using it this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR include?
This PR contains the final completion changes to the patient list modal.