Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-641: Completed Patient List Modal #26

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

vasharma05
Copy link
Member

What does this PR include?

This PR contains the final completion changes to the patient list modal.

image

@vasharma05
Copy link
Member Author

vasharma05 commented Jul 27, 2021

www_screencapture_com_2021-7-27_13_56.mp4

Correction: screen width -> screen height

@FlorianRappl @jonathandick I have tried to show the modal and the workflow too. @FlorianRappl this video also contains the workflow, which I want you to go through, it will help in solving out the queries you pointed above and can you please suggest me something better, if this workflow doesn't look good to you.

@jonathandick I want you to please check the text shown in the toasts and direct if any changes are required.

Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already suggested something better.

  1. Remove the global closeModal.
  2. Remove the openModal.
  3. Call showModal directly in the AddPastVisitOverflowMenuItem component:
const openModal = React.useCallback(() => {
  const dispose = showModal('add-patient-to-patient-list-modal', {
    close: () => dispose();
  });
}, []);

@vasharma05
Copy link
Member Author

Thanks @FlorianRappl ! I didn't think of using it this way.
Thanks alot!

Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianRappl FlorianRappl merged commit aaaa4d3 into openmrs:main Jul 27, 2021
@vasharma05 vasharma05 deleted the patient-list-modal branch August 5, 2021 15:09
makombe pushed a commit to makombe/openmrs-esm-patient-management that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants