Fixed patient form editing not working. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added first fns for offline editing.
|
There are already some preparations for offline editing in here. These are not the focus of this PR and can absolutely change again in following PRs. The focus of this one is mainly making the form work again when online. |
manuelroemer
commented
May 27, 2021
...ges/esm-patient-registration-app/src/patient-registration/patient-registration.component.tsx
Show resolved
Hide resolved
manuelroemer
commented
May 27, 2021
| // `=== false` is here on purpose (`inEditMode` is a triple state value). | ||
| // We *only* want to set initial address field values when *creating* a patient. | ||
| // We must wait until after loading for this info. | ||
| if (inEditMode === false) { |
There was a problem hiding this comment.
This is the only exception to my previous comment.
Overwriting patient address data from the backend with default values seemed wrong to me. I can remove the if here though if that's a wrong assumption on my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patient registration form was not functional as it didn't display the current values of a patient at the moment.
The changes in here (re-)enable that functionality, at least partially.
Required for future work on making the edit form available offline.