working on calendar view #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
requested changes
Jan 13, 2023
Comment on lines
15
to
16
| // width: 100%; | ||
| // float: right; |
There was a problem hiding this comment.
Please remove this commented out code
| }: { | ||
| type: CalendarType; | ||
| events: { appointmentDate: string; service: Array<any>; [key: string]: any }[]; |
There was a problem hiding this comment.
This can be extracted to DailyCalendarViewProps to make it more readable, also avoid using Array<any> provide the correct type for it.
| <div className={styles.container}> | ||
| <DailyHeader type={type} currentDate={currentDate} setCurrentDate={setCurrentDate} events={events} /> | ||
| <div className={styles.wrapper}> | ||
| {type === 'daily' ? ( |
There was a problem hiding this comment.
This component is DailyCalendarView therefore no need to have this check here
| <> | ||
| <div className={styles.cellComponent}> | ||
| <div className={styles[type === 'daily' ? 'daily-cell' : '']}> | ||
| {type === 'daily' ? <small>{dateTime.minute(0).format('h a')}</small> : null} |
| min-height: 40px; | ||
| width: 100%; | ||
| &:nth-child(-n + 24) { | ||
| // border-top: 1px solid colors.$gray-20; |
Comment on lines
9
to
13
| const Format = { | ||
| monthly: 'month', | ||
| weekly: 'week', | ||
| daily: 'day', | ||
| } as const; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Daily,weekly,and monthly Calendar view design
Screenshots
None.
Related Issue
None.
Other
None.