Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search input height #9

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Fix search input height #9

merged 1 commit into from
Jun 17, 2021

Conversation

donaldkibet
Copy link
Member

Description

Provide carbon Search component with the prop size. By default, it should assume size='xl' seems like by default it assumes the smallest size as shown here am setting it explicitly to xl

Screenshoot

before

Screenshot 2021-06-17 at 16 01 24

after

Screenshot 2021-06-17 at 16 00 29

@donaldkibet donaldkibet requested a review from FlorianRappl June 17, 2021 13:06
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍻

@FlorianRappl FlorianRappl merged commit cc92bd6 into main Jun 17, 2021
@FlorianRappl FlorianRappl deleted the search-bar branch June 17, 2021 14:52
CynthiaKamau pushed a commit to CynthiaKamau/openmrs-esm-patient-management that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants