RESTWS-641: Add support for MIME types when posting complexObs value in json request #360
Conversation
Ruhanga
changed the title
Ruhanga
changed the title
|
Can you include the ticket id in the commit message as required at? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
|
My screen shows me the ticket Id is included. (As in, "RESTWS-641: Add support for MIME types when posting complexObs value in json request" ). I also tried to change the message with git commit --amend. Hope the ticket id appears now. Or may maybe am missing some obvious point, any help is highly appreciated. Thank you. cc @dkayiwa |
|
Can you look at the commit message from here? d1c9557 |
| import java.io.InputStream; | ||
| import java.util.List; | ||
| import java.util.Locale; | ||
| import static org.junit.Assert.*; |
There was a problem hiding this comment.
Did you take a look at this? https://wiki.openmrs.org/display/docs/Java+Conventions#JavaConventions-Donotusewildcardimports
There was a problem hiding this comment.
Conventions followed @dkayiwa.
|
@dkayiwa , yes Sir. |
Ruhanga
force-pushed
the
RESTWS-641
branch
2 times, most recently
from
b7331f9 to
696bb81
Compare
| ComplexData complexData = new ComplexData(obs.getUuid() + ".raw", new ByteArrayInputStream(bytes)); | ||
| String extension = "raw"; | ||
| //Try to extract extension from the MIME type if it is provided in value | ||
| if (value.toString().indexOf("data:") == 0) { |
There was a problem hiding this comment.
The above test is a bit confusing at the first glance. I thought you are testing for absence of mime type with a return value of 0. It took me time to discover that you are actually checking if it starts with it. Don't you think startsWith would be clearer?
ibacher
force-pushed
the
master
branch
2 times, most recently
from
f9c73bb to
2a4407f
Compare
Hello reviewer,
I'd like to have this reviewed.
link to ticket https://issues.openmrs.org/browse/RESTWS-641