RESTWS-755: Modify user resource to include email property which would enable a user email to be edited from reference application #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilanthas
suggested changes
Aug 22, 2019
| } | ||
| else if (rep instanceof FullRepresentation) { | ||
| description.addProperty("email"); | ||
| } |
There was a problem hiding this comment.
Whats the purpose of adding these if else conditions ? Both conditions are doing the same thing.
There was a problem hiding this comment.
The first condition checks for defaultRepresentation, second condition checks for Full representation
There was a problem hiding this comment.
Yeah but after checking its doing the same thing description.addProperty("email");
| ModelImpl model = (ModelImpl) super.getGETModel(rep); | ||
| if (rep instanceof DefaultRepresentation || rep instanceof FullRepresentation) { | ||
| model | ||
| .property("email", new StringProperty()); |
There was a problem hiding this comment.
Is this code formatted properly ?
There was a problem hiding this comment.
I don't know why it displayed that way. I'd have to fix it
…ser email to be edited from reference application, fixed failing tests.
tenas97
changed the title
ibacher
force-pushed
the
master
branch
2 times, most recently
from
f9c73bb to
2a4407f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user email to be edited from reference application
Description of what I changed
Modify user resource to include email property which would enable a user email to be edited from reference application
Issue I worked on
https://issues.openmrs.org/browse/RESTWS-755?filter=-2
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
No? -> read here on how to squash multiple commits into one
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master