Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and cleanup for Windows/UWP #133

Merged
merged 12 commits into from
Dec 11, 2022
Merged

Refactoring and cleanup for Windows/UWP #133

merged 12 commits into from
Dec 11, 2022

Conversation

janusw
Copy link
Member

@janusw janusw commented Dec 9, 2022

This PR cleans up the Windows/UWP part of OxyPlot.Xamarin, which is special in that it depends on the package Oxyplot.Windows, which lives outside of this repo.

Therefore I first copied the code from the oxyplot-uwp repo into oxyplot-xamarin, in analogy to the other platforms. Since the OxyPlot.Windows project did not actually build, I made some changes to fix that. Then I consolidated the package versions across the sln, updated the nuspec and did some further cleanup.

@objorke @VisualMelon I hope this restructuring is ok with you.

janusw added 12 commits December 7, 2022 21:46
* uap targets are not supported in sdk-style projects directly
  (only via MSBuild.Sdk.Extras)
* fixing errors about duplicate attributes
* remove dependency on OxyPlot.Windows
* instead add OxyPlot.Windows.* directly into the package
* this is now included in the OxyPlot.Xamarin.Forms package
* should not be needed any more
  (and references and old Xamarin.Forms version)
@VisualMelon
Copy link

Is there a reason that the Windows/UWP stuff can't stay in its own repo? It's fine to have an inter-repo dependence so long as it is simple and documented or managed nicely with git sub-module. I may be missing the point entirely.

@janusw
Copy link
Member Author

janusw commented Dec 10, 2022

Is there a reason that the Windows/UWP stuff can't stay in its own repo?

Well, it certainly could, but honestly that does not make much sense to me.

First of all, there does not seem to be much general interest in the UPW port on its own. The repo is a one-commit drop from the main oxyplot repo AFAICS, which has not been touched ever since and does not build at all.

I don't personally have much incentive for maintaining yet another package, with all its interdependencies etc. Updating the Xamarin package is much easier with everything in one place, and that's also the way it is done for the other platforms (Android, iOS, Mac). I have abandoned the Xamarin.Android, Xamarin.iOS and Xamarin.Mac packages and only plan to further maintain the Xamarin.Forms package, which IMHO is the future and can be developed into a MAUI package at some point. The platform-specific Xamarin-variants are not very relevant any more, I think (but in principle they can still be used via the Xamarin.Forms package, which contains everything now).

I would like to treat Windows/UWP in the same way as the other platforms, thus deprecating OxyPlot.Windows (which is misnamed anyway; should rather be called OxyPlot.UWP) and include it directly in OxyPlot.Xamarin.Forms. This reduces the maintenance overhead, makes it simpler to consistenly update everything to new package versions etc (and, as for the other platforms, it is still possible to use the UWP parts for a pure Xamarin.UWP app).

In any case I think UWP will be irrelevant and outdated pretty soon, and will be replaced by WinUI 3 (which is also used for MAUI). I would like to move all of this towards MAUI as fast as possible, and dragging along too much historical ballast will only slow down this process and make it unnecessarily complicated.

I hope I explained my reasoning well and it does make some sense to you ;)

@VisualMelon
Copy link

If it makes it easy for you, then I'm happy.

@janusw
Copy link
Member Author

janusw commented Dec 11, 2022

If it makes it easy for you, then I'm happy.

Ok, then. Thanks for your understanding! 😊

I'm going to merge this PR and add a deprecation notice to oxyplot-uwp, which links to oxyplot-xamarin.

Btw, we can of course easily publish a pure UWP package again in the future, if we decide that it's necessary. But I really think there is zero value in keeping it in a separate repo (in particular in a one-commit repo without any historical context).

@janusw janusw merged commit a68bdee into oxyplot:develop Dec 11, 2022
@janusw janusw deleted the uwp branch December 11, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants