Update OxyPlot.Core to 2.1.0 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did some basic checks with the nupkg built from this PR today, using a Xamarin.Forms app that shows a simple LineSeries plot. This kind of plot is still rendered correctly on Android and iOS. 👍 |
|
Looking through the code quickly, nothing looks off; I'd suggest you double-check the bar series example: you may need to qualify the axis keys. |
* fixing errors like this in GHA: error CS0012: The type 'ValueType' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
* fixing errors like this in GHA: error CS0012: The type 'Attribute' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
* "BarSeries requires a CategoryAxis on the Y Axis"
Thanks for the review!
Indeed the BarSeries example in the SimpleDemo app was failing at runtime. I fixed it now by qualifying the axis keys, as you suggested. With that addition, this PR should be complete, I guess. |
This was referenced Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates OxyPlot.Core from 2.0.0 to 2.1.0 and implements the necessary API changes. It should fix #124.
It would be great if some OxyPlot maintainer could have a look at this. @objorke @VisualMelon