added method in OAuth for checking redirect url #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
suggested changes
Aug 17, 2017
app/library/Github/OAuth.php
Outdated
| * | ||
| * @return string | ||
| */ | ||
| protected function getRedirectGitPath($url, $endSlash = true) |
There was a problem hiding this comment.
@sergeysviridenko Where is this method used? :)
sergeysviridenko
force-pushed
the
3.git_redirect_method
branch
4 times, most recently
from
699e62f to
16ad361
Compare
sergeysviridenko
changed the title
sergeysviridenko
force-pushed
the
3.git_redirect_method
branch
2 times, most recently
from
e3cf11e to
3a7d61f
Compare
sergeyklay
suggested changes
Aug 22, 2017
app/library/Github/OAuth.php
Outdated
| protected function checkRedirectGitPath($url) | ||
| { | ||
| if (!filter_var($url, FILTER_VALIDATE_URL, FILTER_FLAG_SCHEME_REQUIRED | FILTER_FLAG_HOST_REQUIRED | | ||
| FILTER_FLAG_PATH_REQUIRED)) { |
There was a problem hiding this comment.
$validationFlags = FILTER_FLAG_SCHEME_REQUIRED | FILTER_FLAG_HOST_REQUIRED | FILTER_FLAG_PATH_REQUIRED;
if (!filter_var($url, FILTER_VALIDATE_URL, $validationFlags)) {
// ...
}|
|
||
| namespace Phosphorum\Exception; | ||
|
|
||
| class UrlException extends \LogicException |
There was a problem hiding this comment.
InvalidCalbackUrlException
app/library/Github/OAuth.php
Outdated
| } | ||
|
|
||
| if (stristr($url, '://', true) != $this->request->getScheme()) { | ||
| $errorMessage = 'HyperText Protocol in your application and in your setting file are different. '; |
There was a problem hiding this comment.
The same protocol should be used for the authorization callback URL and forum settings.
sergeysviridenko
force-pushed
the
3.git_redirect_method
branch
from
3a7d61f to
e8525c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Added method for checking
GITHUB_REDIRECT_URIparam from Github authorizationThanks