Skip to content

Commit 8a5bd50

Browse files
committed
update some for flag helper
1 parent a134fba commit 8a5bd50

File tree

3 files changed

+37
-2
lines changed

3 files changed

+37
-2
lines changed

Diff for: src/Helper/FlagHelper.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public static function isOptionValue($val): bool
112112
*/
113113
public static function isValidName(string $name): bool
114114
{
115-
return preg_match('#^\w+$#', $name) === 1;
115+
return preg_match('#^\w[\w-]{0,36}$#', $name) === 1;
116116
}
117117

118118
/**

Diff for: test/ColorTagTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public function testParseNestTag(): void
106106

107107
// nested Tags
108108
$text = ColorTag::parse('<info>INFO <cyan>CYAN mess</cyan>age</info>', true);
109-
echo $text, PHP_EOL;
109+
echo 'nested: ' . $text, PHP_EOL;
110110
$this->assertSame("\033[0;32mINFO \033[0;36mCYAN mess\033[0mage\033[0m", $text);
111111

112112
Color::resetConfig();

Diff for: test/Helper/FlagHelperTest.php

+35
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
<?php declare(strict_types=1);
2+
3+
namespace Toolkit\CliTest\Helper;
4+
5+
use PHPUnit\Framework\TestCase;
6+
use Toolkit\Cli\Helper\FlagHelper;
7+
8+
/**
9+
* class FlagHelperTest
10+
*/
11+
class FlagHelperTest extends TestCase
12+
{
13+
public function testIsValidName(): void
14+
{
15+
$tests = [
16+
'name' => true,
17+
'name1' => true,
18+
'some-name' => true,
19+
'some_name' => true,
20+
'someName' => true,
21+
'SomeName' => true,
22+
'_2' => true,
23+
'_someName' => true,
24+
'_SomeName' => true,
25+
'_name-' => true,
26+
'-name' => false,
27+
' name' => false,
28+
'+name' => false,
29+
];
30+
31+
foreach ($tests as $name => $ok) {
32+
$this->assertSame($ok, FlagHelper::isValidName($name));
33+
}
34+
}
35+
}

0 commit comments

Comments
 (0)