Skip to content

Commit 01c8fe8

Browse files
committed
Convert strcmp() usage to zend_string_equals_literal()
1 parent b426966 commit 01c8fe8

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

ext/pdo/pdo_stmt.c

+4-6
Original file line numberDiff line numberDiff line change
@@ -2018,7 +2018,7 @@ PHP_METHOD(PDOStatement, getIterator)
20182018
/* {{{ overloaded handlers for PDOStatement class */
20192019
static zval *dbstmt_prop_write(zend_object *object, zend_string *name, zval *value, void **cache_slot)
20202020
{
2021-
if (strcmp(ZSTR_VAL(name), "queryString") == 0) {
2021+
if (zend_string_equals_literal(name, "queryString")) {
20222022
zend_throw_error(NULL, "Property queryString is read only");
20232023
return value;
20242024
} else {
@@ -2028,7 +2028,7 @@ static zval *dbstmt_prop_write(zend_object *object, zend_string *name, zval *val
20282028

20292029
static void dbstmt_prop_delete(zend_object *object, zend_string *name, void **cache_slot)
20302030
{
2031-
if (strcmp(ZSTR_VAL(name), "queryString") == 0) {
2031+
if (zend_string_equals_literal(name, "queryString")) {
20322032
zend_throw_error(NULL, "Property queryString is read only");
20332033
} else {
20342034
zend_std_unset_property(object, name, cache_slot);
@@ -2282,8 +2282,7 @@ static zval *row_prop_read(zend_object *object, zend_string *name, int type, voi
22822282
return rv;
22832283
}
22842284
}
2285-
if (strcmp(ZSTR_VAL(name), "queryString") == 0) {
2286-
//zval_ptr_dtor(rv);
2285+
if (zend_string_equals_literal(name, "queryString")) {
22872286
return zend_std_read_property(&stmt->std, name, type, cache_slot, rv);
22882287
}
22892288
}
@@ -2324,8 +2323,7 @@ static zval *row_dim_read(zend_object *object, zval *member, int type, zval *rv)
23242323
return rv;
23252324
}
23262325
}
2327-
if (strcmp(Z_STRVAL_P(member), "queryString") == 0) {
2328-
//zval_ptr_dtor(rv);
2326+
if (zend_string_equals_literal(Z_STR_P(member), "queryString")) {
23292327
return zend_std_read_property(&stmt->std, Z_STR_P(member), type, NULL, rv);
23302328
}
23312329
}

0 commit comments

Comments
 (0)