Skip to content

Commit 37504f1

Browse files
committed
Port OpenSSL gh10495, gh13860 and gh9310 test to use ephemeral ports
1 parent 44a9154 commit 37504f1

File tree

3 files changed

+19
-29
lines changed

3 files changed

+19
-29
lines changed

ext/openssl/tests/gh10495.phpt

+6-12
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,7 @@ $peerName = 'gh10495';
1515
$clientCode = <<<'CODE'
1616
$context = stream_context_create(['ssl' => ['verify_peer' => false, 'peer_name' => '%s']]);
1717
18-
phpt_wait('server');
19-
phpt_notify('proxy');
20-
21-
phpt_wait('proxy');
22-
$fp = stream_socket_client("tlsv1.2://127.0.0.1:10012", $errornum, $errorstr, 1, STREAM_CLIENT_CONNECT, $context);
18+
$fp = stream_socket_client("tlsv1.2://{{ ADDR }}", $errornum, $errorstr, 1, STREAM_CLIENT_CONNECT, $context);
2319
2420
phpt_wait('proxy');
2521
@@ -38,8 +34,8 @@ $serverCode = <<<'CODE'
3834
$context = stream_context_create(['ssl' => ['local_cert' => '%s']]);
3935
4036
$flags = STREAM_SERVER_BIND|STREAM_SERVER_LISTEN;
41-
$fp = stream_socket_server("tlsv1.2://127.0.0.1:10011", $errornum, $errorstr, $flags, $context);
42-
phpt_notify();
37+
$fp = stream_socket_server("tlsv1.2://127.0.0.1:0", $errornum, $errorstr, $flags, $context);
38+
phpt_notify_server_start($fp);
4339
4440
$conn = stream_socket_accept($fp);
4541
fwrite($conn, 'warmup');
@@ -50,14 +46,12 @@ CODE;
5046
$serverCode = sprintf($serverCode, $certFile);
5147

5248
$proxyCode = <<<'CODE'
53-
phpt_wait();
54-
55-
$upstream = stream_socket_client("tcp://127.0.0.1:10011", $errornum, $errorstr, 3000, STREAM_CLIENT_CONNECT);
49+
$upstream = stream_socket_client("tcp://{{ ADDR }}", $errornum, $errorstr, 3000, STREAM_CLIENT_CONNECT);
5650
stream_set_blocking($upstream, false);
5751
5852
$flags = STREAM_SERVER_BIND|STREAM_SERVER_LISTEN;
59-
$server = stream_socket_server("tcp://127.0.0.1:10012", $errornum, $errorstr, $flags);
60-
phpt_notify();
53+
$server = stream_socket_server("tcp://127.0.0.1:0", $errornum, $errorstr, $flags);
54+
phpt_notify_server_start($server);
6155
$conn = stream_socket_accept($server);
6256
stream_set_blocking($conn, false);
6357

ext/openssl/tests/gh13860.phpt

+3-4
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ if (!function_exists("proc_open")) die("skip no proc_open");
99
--FILE--
1010
<?php
1111
$serverCode = <<<'CODE'
12-
$serverUri = "tcp://127.0.0.1:64326";
12+
$serverUri = "tcp://127.0.0.1:0";
1313
$serverFlags = STREAM_SERVER_BIND | STREAM_SERVER_LISTEN;
1414
$serverCtx = stream_context_create();
1515
1616
$server = stream_socket_server($serverUri, $errno, $errstr, $serverFlags, $serverCtx);
17-
phpt_notify();
17+
phpt_notify_server_start($server);
1818
1919
$client = @stream_socket_accept($server);
2020
if ($client) {
@@ -26,10 +26,9 @@ $serverCode = <<<'CODE'
2626
CODE;
2727

2828
$clientCode = <<<'CODE'
29-
$serverUri = "tcp://127.0.0.1:64326";
29+
$serverUri = "tcp://{{ ADDR }}";
3030
$clientFlags = STREAM_CLIENT_CONNECT;
3131
32-
phpt_wait();
3332
$fp = stream_socket_client($serverUri);
3433
stream_set_blocking($fp, false);
3534

ext/openssl/tests/gh9310.phpt

+10-13
Original file line numberDiff line numberDiff line change
@@ -29,29 +29,28 @@ copy(__DIR__ . '/sni_server_uk_cert.pem', $baseDir . '/sni_server_uk_cert.pem');
2929
$serverCodeTemplate = <<<'CODE'
3030
ini_set('log_errors', 'On');
3131
ini_set('open_basedir', __DIR__ . '/gh9310');
32-
$serverUri = "ssl://127.0.0.1:64321";
32+
$serverUri = "ssl://127.0.0.1:0";
3333
$serverFlags = STREAM_SERVER_BIND | STREAM_SERVER_LISTEN;
3434
$serverCtx = stream_context_create(['ssl' => [
3535
'local_cert' => '%s',
3636
'local_pk' => '%s',
3737
]]);
3838
3939
$sock = stream_socket_server($serverUri, $errno, $errstr, $serverFlags, $serverCtx);
40-
phpt_notify();
40+
phpt_notify_server_start($sock);
4141
4242
$link = stream_socket_accept($sock);
4343
CODE;
4444

4545
$clientCode = <<<'CODE'
46-
$serverUri = "ssl://127.0.0.1:64321";
46+
$serverUri = "ssl://{{ ADDR }}";
4747
$clientFlags = STREAM_CLIENT_CONNECT;
4848
4949
$clientCtx = stream_context_create(['ssl' => [
5050
'verify_peer' => false,
5151
'verify_peer_name' => false
5252
]]);
5353
54-
phpt_wait();
5554
@stream_socket_client($serverUri, $errno, $errstr, 2, $clientFlags, $clientCtx);
5655
CODE;
5756

@@ -65,8 +64,8 @@ $sniServerCodeV1 = <<<'CODE'
6564
]
6665
]]);
6766
68-
$server = stream_socket_server('tls://127.0.0.1:64321', $errno, $errstr, $flags, $ctx);
69-
phpt_notify();
67+
$server = stream_socket_server('tls://127.0.0.1:0', $errno, $errstr, $flags, $ctx);
68+
phpt_notify_server_start($server);
7069
7170
stream_socket_accept($server);
7271
CODE;
@@ -84,8 +83,8 @@ $sniServerCodeV2 = <<<'CODE'
8483
]
8584
]]);
8685
87-
$server = stream_socket_server('tls://127.0.0.1:64321', $errno, $errstr, $flags, $ctx);
88-
phpt_notify();
86+
$server = stream_socket_server('tls://127.0.0.1:0', $errno, $errstr, $flags, $ctx);
87+
phpt_notify_server_start($server);
8988
9089
stream_socket_accept($server);
9190
CODE;
@@ -103,8 +102,8 @@ $sniServerCodeV3 = <<<'CODE'
103102
]
104103
]]);
105104
106-
$server = stream_socket_server('tls://127.0.0.1:64321', $errno, $errstr, $flags, $ctx);
107-
phpt_notify();
105+
$server = stream_socket_server('tls://127.0.0.1:0', $errno, $errstr, $flags, $ctx);
106+
phpt_notify_server_start($server);
108107
109108
stream_socket_accept($server);
110109
CODE;
@@ -115,11 +114,9 @@ $sniClientCodeTemplate = <<<'CODE'
115114
'cafile' => __DIR__ . '/sni_server_ca.pem',
116115
];
117116
118-
phpt_wait();
119-
120117
$ctxArr['peer_name'] = '%s';
121118
$ctx = stream_context_create(['ssl' => $ctxArr]);
122-
@stream_socket_client("tls://127.0.0.1:64321", $errno, $errstr, 1, $flags, $ctx);
119+
@stream_socket_client("tls://{{ ADDR }}", $errno, $errstr, 1, $flags, $ctx);
123120
CODE;
124121

125122
$serverCode = sprintf($serverCodeTemplate, $baseDirCertFile . "\0test", $baseDirPkFile);

0 commit comments

Comments
 (0)