Fix lazy proxy calling magic methods twice #18039
Conversation
Zend/zend_object_handlers.c
Outdated
| @@ -970,6 +982,43 @@ static zend_always_inline bool property_uses_strict_types(void) { | |||
| && ZEND_CALL_USES_STRICT_TYPES(EG(current_execute_data)); | |||
| } | |||
|
|
|||
| static zend_always_inline zval *forward_write_to_lazy_object(zend_object *zobj, | |||
There was a problem hiding this comment.
I don't know if it's worth to always_inline this?
There was a problem hiding this comment.
Indeed, I will check if it makes a noticeable difference
There was a problem hiding this comment.
I've removed the always inline attribute
| var_dump($obj->prop); | ||
|
|
||
| ?> | ||
| --EXPECTF-- |
There was a problem hiding this comment.
I don't understand why the __get function should get called before instantiating the object? I.e. why does "C::__get" appear before "init"?
There was a problem hiding this comment.
It’s how lazy objects are supposed to behave: we interact primarily with the proxy (we execute the proxy’s code), but any access to its state is forwarded to the real instance.
So here we execute the getter, which tries to access a property. This triggers initialization before the access is forwarded.
There was a problem hiding this comment.
Okay I see, not what I intuitively expected but it makes sense
There was a problem hiding this comment.
I suppose there's also an implicit assumption here that the initialized properties does not contain dynamic properties. If it does, the initializer would need to be called before __get, to ensure that the property is actually still does not exist after the initializer has been called.
Fixes GH-18038.
Guard the underlying property, so that the forwarded operation accesses the property directly.