ext/curl: Various minor clean-up refactorings #18042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Mar 14, 2025
ext/curl/interface.c
Outdated
| @@ -2466,7 +2465,7 @@ PHP_FUNCTION(curl_exec) | |||
|
|
|||
| if (!Z_ISUNDEF(ch->handlers.std_err)) { | |||
| php_stream *stream; | |||
| stream = (php_stream*)zend_fetch_resource2_ex(&ch->handlers.std_err, NULL, php_file_le_stream(), php_file_le_pstream()); | |||
| php_stream_from_zval_no_verify(stream, &ch->handlers.std_err); | |||
There was a problem hiding this comment.
nit: I think you would need to change other instances as well e.g. line 152, because now you have named resource, i.e. stream, wdyt ?
There was a problem hiding this comment.
Ah right, I somehow missed them.
I'll split this into a different commit.
Girgias
force-pushed
the
curl-minor-refactoring
branch
from
4833440 to
7b76aec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.