Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zend_get_callable_name: Return underlying callable’s name for fake closures #18063

Merged
merged 2 commits into from
Mar 17, 2025
Merged

zend_get_callable_name: Return underlying callable’s name for fake closures #18063

merged 2 commits into from
Mar 17, 2025

Conversation

TimWolla
Copy link
Member

Fixes #18062

@TimWolla TimWolla requested a review from dstogov as a code owner March 14, 2025 09:49
@TimWolla TimWolla force-pushed the zend-get-callable-name-fcc branch from c05a85d to c33f6e0 Compare March 14, 2025 10:17
dstogov
dstogov reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a problem in the change, but I think this should be committed into master only.

@TimWolla TimWolla force-pushed the zend-get-callable-name-fcc branch from c33f6e0 to 4d122cf Compare March 17, 2025 08:52
@TimWolla TimWolla changed the base branch from PHP-8.3 to master March 17, 2025 09:38
@TimWolla TimWolla merged commit 6962540 into php:master Mar 17, 2025
10 checks passed
@TimWolla TimWolla deleted the zend-get-callable-name-fcc branch March 17, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_callable(func(...), callable_name: $name) for first class callables returns wrong name
2 participants
@TimWolla @dstogov