Add (void) cast
#18115
Merged
Add (void) cast
#18115
+158
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
reviewed
Mar 20, 2025
nielsdos
reviewed
Mar 21, 2025
| zend_op *opline; | ||
|
|
||
| zend_do_extended_fcall_begin(); | ||
| zend_compile_expr(&expr_node, expr_ast); |
There was a problem hiding this comment.
I guess you could optimize it a bit by not even handling IS_CONSTANT_AST in the first place, i.e. early returning.
I would still keep the IS_CONST handling below though because it generalises.
There was a problem hiding this comment.
As with the (void)(bool) cast, this feels like needless added complexity for a case that is unlikely to happen in practice and also no longer matters once the file is compiled and OPcached.
iluuu1994
approved these changes
Mar 24, 2025
nielsdos
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/marking_return_value_as_important
Spun out of #17599, since the
(void)cast implementation is fully independent of the#[\NoDiscard]implementation and sufficiently complex on its own, allowing for an easier review.