Skip to content

Commit 154e5f5

Browse files
committed
[PGPRO-11597] Redesigned the launch of isolation tests
"CREATE/DROP EXTENSION" has been removed from spec. Instead, the "ISOLATION_OPTS" variable is used. Tags: pg_query_state
1 parent 0c6e36a commit 154e5f5

File tree

4 files changed

+3
-13
lines changed

4 files changed

+3
-13
lines changed

.travis.yml

-2
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,11 @@ env:
3333
- PG_VERSION=13
3434
- PG_VERSION=12 LEVEL=hardcore USE_TPCDS=1
3535
- PG_VERSION=12
36-
- PG_VERSION=11
3736
- PG_VERSION=10
3837
- PG_VERSION=9.6
3938

4039
matrix:
4140
allow_failures:
4241
- env: PG_VERSION=13 LEVEL=hardcore USE_TPCDS=1
43-
- env: PG_VERSION=11
4442
- env: PG_VERSION=10
4543
- env: PG_VERSION=9.6

Makefile

+2-8
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,8 @@ EXTRA_CLEAN = ./isolation_output $(EXTENSION)--$(EXTVERSION).sql \
1313
Dockerfile ./tests/*.pyc ./tmp_stress
1414

1515
ISOLATION = corner_cases
16-
#
17-
# PG11 doesn't support ISOLATION_OPTS variable. We have to use
18-
# "CREATE/DROP EXTENTION" command in spec.
19-
#
20-
# One day, when we'll get rid of PG11, it will be possible to uncomment this
21-
# variable and remove "CREATE EXTENTION" from spec.
22-
#
23-
# ISOLATION_OPTS = --load-extension=pg_query_state
16+
17+
ISOLATION_OPTS = --load-extension=pg_query_state
2418

2519
ifdef USE_PGXS
2620
PG_CONFIG ?= pg_config

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ To install `pg_query_state`, please apply corresponding patches `custom_signal_(
2020
To do this, run the following commands from the postgresql directory:
2121
```
2222
patch -p1 < path_to_pg_query_state_folder/patches/runtime_explain_(PG_VERSION).patch
23-
patch -p1 < path_to_pg_query_state_folder/patches/custom_signal_(PG_VERSION).patch
23+
patch -p1 < path_to_pg_query_state_folder/patches/custom_signals_(PG_VERSION).patch
2424
```
2525

2626
Then execute this in the module's directory:

specs/corner_cases.spec

-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
setup
22
{
3-
CREATE EXTENSION pg_query_state;
43
CREATE ROLE alice;
54
CREATE ROLE bob;
65
CREATE ROLE super SUPERUSER;
@@ -31,7 +30,6 @@ teardown
3130
DROP ROLE super;
3231
DROP ROLE bob;
3332
DROP ROLE alice;
34-
DROP EXTENSION pg_query_state;
3533
}
3634

3735
session "s1"

0 commit comments

Comments
 (0)