Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gridOutput.js #7621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

southwest-git
Copy link

Resolves #7259

Changes:

Some shapes located outside of the canvas and the current check in _gridMap only applies to positive locX and locY but not negative values. The fix is to check for negative values and hence avoiding a negative indexing to an array which causes the issue.

Screenshots of the change:

PR Checklist

Fix for issue 7259 to check for negative locX and locY in gridOutput.js
Copy link

welcome bot commented Mar 11, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@ksen0
Copy link
Member

ksen0 commented Mar 26, 2025

Hi @himanshuukholiya I saw you were active on the related issue here #7259, can you check if this is still relevant? The issue seems to be marked as resolved. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mostly offscreen primitive shapes throws error
2 participants