Raise UserError when tool system_prompt returns a None #1058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
would raise an error at time of model calling
This PR checks defensively checks what is being returned, and will raise a hopefully more informative UserError. Note this all requires a type check override, since returning None is forbidden. However, if we treat user code as input then it's possible to violate at runtime.
Also include a unit test, and for an additional ultra-edgy case of returning a non-string from system_prompt
Fixes #1057