improve logging in shortcuts.py and turn to pytest in test_shortcut.py #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 84.38% 83.04% -1.35%
==========================================
Files 6 6
Lines 237 230 -7
Branches 48 47 -1
==========================================
- Hits 200 191 -9
- Misses 24 26 +2
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
p1c2u
reviewed
Mar 20, 2025
| from typing import Any | ||
| from typing import Hashable | ||
| from typing import Mapping | ||
| from typing import Type |
There was a problem hiding this comment.
I would keep it as it is here.
p1c2u
reviewed
Mar 20, 2025
|
|
||
| if errors: | ||
| error = best_match(errors) | ||
| error.message = f"Validation failed: {error.message}" |
There was a problem hiding this comment.
Would be nice to have it tested
There was a problem hiding this comment.
I studied a little more on my work project.
The solution I proposed adds another line to the log, although it's already clear from the output what's going on.
Returned the logic as it was before my edits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I've been using this project for my autotests for a very long time and I want to make a small contribution.
In this CC, the following was done:
Additionally done:
I will be glad to receive feedback.