Avoid writing to the body after full hijack #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks okay to me, but my only thought is whether we should move this to |
|
Actually a good point, maybe we should (since Do lmk if you want me to split this PR into 2 – happy to do that. |
|
Yes, let's implement the core functionality in |
3 tasks
|
As soon as socketry/protocol-http1#30 lands I can update this PR – will only need |
|
|
|
Updated this PR to match |
ioquatix
reviewed
Apr 5, 2024
ioquatix
force-pushed
the
full-hijack-fix
branch
from
3c3454d to
73c6b38
Compare
|
I tried this out and it's working as expected - thanks! |
ioquatix
pushed a commit
to zarqman/async-http
that referenced
this pull request
Apr 23, 2024
* Handling partially and fully hijacked connections gracefully * A more precise test of hijacked body * Bumping protocol-http1 and updating hijack check * Closing the body after hijack --------- Co-authored-by: Anton Zhuravsky <anton@lunalabs.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the application performs hijacking of http/1.1 connection, the server must not attempt to send any response back to the client. Prior to this change, it was not the case due to imprecise check and has led to an error being logged (the real issue occurred during an attempt to write to a stream that was set to nil, but that's really just a symptom).
The proposed fix simply adds a flag to the connection object so that it is aware of the fact the underlying stream no longer belongs to it and must not be used to send any data over.
Types of Changes
Contribution