Skip to content

Commit ffe9e86

Browse files
mp911dechristophstrobl
authored andcommitted
Adopt to deprecation removals in Commons.
Closes #3051
1 parent 8b32d4c commit ffe9e86

File tree

2 files changed

+23
-22
lines changed

2 files changed

+23
-22
lines changed

src/main/java/org/springframework/data/redis/repository/query/RedisPartTreeQuery.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535
import org.springframework.data.repository.query.ParameterAccessor;
3636
import org.springframework.data.repository.query.ParametersParameterAccessor;
3737
import org.springframework.data.repository.query.QueryMethod;
38-
import org.springframework.data.repository.query.QueryMethodEvaluationContextProvider;
3938
import org.springframework.data.repository.query.ResultProcessor;
4039
import org.springframework.data.repository.query.ReturnedType;
40+
import org.springframework.data.repository.query.ValueExpressionDelegate;
4141
import org.springframework.data.repository.query.parser.AbstractQueryCreator;
4242
import org.springframework.data.util.ReflectionUtils;
4343
import org.springframework.data.util.Streamable;
@@ -54,9 +54,9 @@ public class RedisPartTreeQuery extends KeyValuePartTreeQuery {
5454

5555
private final RedisKeyValueAdapter adapter;
5656

57-
public RedisPartTreeQuery(QueryMethod queryMethod, QueryMethodEvaluationContextProvider evaluationContextProvider,
57+
public RedisPartTreeQuery(QueryMethod queryMethod, ValueExpressionDelegate valueExpressionDelegate,
5858
KeyValueOperations template, Class<? extends AbstractQueryCreator<?, ?>> queryCreator) {
59-
super(queryMethod, evaluationContextProvider, template, queryCreator);
59+
super(queryMethod, valueExpressionDelegate, template, queryCreator);
6060
this.adapter = (RedisKeyValueAdapter) template.getKeyValueAdapter();
6161
}
6262

src/test/java/org/springframework/data/redis/repository/configuration/RedisRepositoryConfigurationExtensionUnitTests.java

+20-19
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.springframework.core.env.StandardEnvironment;
2929
import org.springframework.core.io.ResourceLoader;
3030
import org.springframework.core.io.support.PathMatchingResourcePatternResolver;
31+
import org.springframework.core.type.AnnotationMetadata;
3132
import org.springframework.core.type.StandardAnnotationMetadata;
3233
import org.springframework.data.annotation.Id;
3334
import org.springframework.data.keyvalue.repository.KeyValueRepository;
@@ -46,12 +47,12 @@
4647
*/
4748
class RedisRepositoryConfigurationExtensionUnitTests {
4849

49-
private StandardAnnotationMetadata metadata = new StandardAnnotationMetadata(Config.class, true);
50+
private AnnotationMetadata metadata = AnnotationMetadata.introspect(Config.class);
5051
private ResourceLoader loader = new PathMatchingResourcePatternResolver();
5152
private Environment environment = new StandardEnvironment();
5253
private BeanDefinitionRegistry registry = new DefaultListableBeanFactory();
5354
private RepositoryConfigurationSource configurationSource = new AnnotationRepositoryConfigurationSource(metadata,
54-
EnableRedisRepositories.class, loader, environment, registry);
55+
EnableRedisRepositories.class, loader, environment, registry, null);
5556

5657
private RedisRepositoryConfigurationExtension extension = new RedisRepositoryConfigurationExtension();
5758

@@ -75,46 +76,46 @@ void isNotStrictMatchIfDomainTypeIsNotAnnotatedWithDocument() {
7576
@Test // DATAREDIS-491
7677
void picksUpEnableKeyspaceEventsOnStartupCorrectly() {
7778

78-
metadata = new StandardAnnotationMetadata(Config.class, true);
79-
BeanDefinitionRegistry beanDefintionRegistry = getBeanDefinitionRegistry();
79+
metadata = AnnotationMetadata.introspect(Config.class);
80+
BeanDefinitionRegistry bdr = getBeanDefinitionRegistry();
8081

81-
assertThat(getEnableKeyspaceEvents(beanDefintionRegistry)).isEqualTo((Object) EnableKeyspaceEvents.ON_STARTUP);
82+
assertThat(getEnableKeyspaceEvents(bdr)).isEqualTo((Object) EnableKeyspaceEvents.ON_STARTUP);
8283
}
8384

8485
@Test // DATAREDIS-491
8586
void picksUpEnableKeyspaceEventsDefaultCorrectly() {
8687

87-
metadata = new StandardAnnotationMetadata(ConfigWithKeyspaceEventsDisabled.class, true);
88-
BeanDefinitionRegistry beanDefintionRegistry = getBeanDefinitionRegistry();
88+
metadata = AnnotationMetadata.introspect(ConfigWithKeyspaceEventsDisabled.class);
89+
BeanDefinitionRegistry bdr = getBeanDefinitionRegistry();
8990

90-
assertThat(getEnableKeyspaceEvents(beanDefintionRegistry)).isEqualTo((Object) EnableKeyspaceEvents.OFF);
91+
assertThat(getEnableKeyspaceEvents(bdr)).isEqualTo((Object) EnableKeyspaceEvents.OFF);
9192
}
9293

9394
@Test // DATAREDIS-505
9495
void picksUpDefaultKeyspaceNotificationsConfigParameterCorrectly() {
9596

9697
metadata = new StandardAnnotationMetadata(Config.class, true);
97-
BeanDefinitionRegistry beanDefintionRegistry = getBeanDefinitionRegistry();
98+
BeanDefinitionRegistry bdr = getBeanDefinitionRegistry();
9899

99-
assertThat(getKeyspaceNotificationsConfigParameter(beanDefintionRegistry)).isEqualTo((Object) "Ex");
100+
assertThat(getKeyspaceNotificationsConfigParameter(bdr)).isEqualTo((Object) "Ex");
100101
}
101102

102103
@Test // DATAREDIS-505
103104
void picksUpCustomKeyspaceNotificationsConfigParameterCorrectly() {
104105

105106
metadata = new StandardAnnotationMetadata(ConfigWithKeyspaceEventsEnabledAndCustomEventConfig.class, true);
106-
BeanDefinitionRegistry beanDefintionRegistry = getBeanDefinitionRegistry();
107+
BeanDefinitionRegistry bdr = getBeanDefinitionRegistry();
107108

108-
assertThat(getKeyspaceNotificationsConfigParameter(beanDefintionRegistry)).isEqualTo((Object) "KEA");
109+
assertThat(getKeyspaceNotificationsConfigParameter(bdr)).isEqualTo((Object) "KEA");
109110
}
110111

111112
@Test // DATAREDIS-1049
112113
void explicitlyEmptyKeyspaceNotificationsConfigParameterShouldBeCapturedCorrectly() {
113114

114115
metadata = new StandardAnnotationMetadata(ConfigWithEmptyConfigParameter.class, true);
115-
BeanDefinitionRegistry beanDefintionRegistry = getBeanDefinitionRegistry();
116+
BeanDefinitionRegistry bdr = getBeanDefinitionRegistry();
116117

117-
assertThat(getKeyspaceNotificationsConfigParameter(beanDefintionRegistry)).isEqualTo("");
118+
assertThat(getKeyspaceNotificationsConfigParameter(bdr)).isEqualTo("");
118119
}
119120

120121
private static void assertDoesNotHaveRepo(Class<?> repositoryInterface,
@@ -147,7 +148,7 @@ private BeanDefinitionRegistry getBeanDefinitionRegistry() {
147148
BeanDefinitionRegistry registry = new SimpleBeanDefinitionRegistry();
148149

149150
RepositoryConfigurationSource configurationSource = new AnnotationRepositoryConfigurationSource(metadata,
150-
EnableRedisRepositories.class, loader, environment, registry);
151+
EnableRedisRepositories.class, loader, environment, registry, null);
151152

152153
RedisRepositoryConfigurationExtension extension = new RedisRepositoryConfigurationExtension();
153154

@@ -156,13 +157,13 @@ private BeanDefinitionRegistry getBeanDefinitionRegistry() {
156157
return registry;
157158
}
158159

159-
private Object getEnableKeyspaceEvents(BeanDefinitionRegistry beanDefintionRegistry) {
160-
return beanDefintionRegistry.getBeanDefinition("redisKeyValueAdapter").getPropertyValues()
160+
private Object getEnableKeyspaceEvents(BeanDefinitionRegistry bdr) {
161+
return bdr.getBeanDefinition("redisKeyValueAdapter").getPropertyValues()
161162
.getPropertyValue("enableKeyspaceEvents").getValue();
162163
}
163164

164-
private Object getKeyspaceNotificationsConfigParameter(BeanDefinitionRegistry beanDefintionRegistry) {
165-
return beanDefintionRegistry.getBeanDefinition("redisKeyValueAdapter").getPropertyValues()
165+
private Object getKeyspaceNotificationsConfigParameter(BeanDefinitionRegistry bdr) {
166+
return bdr.getBeanDefinition("redisKeyValueAdapter").getPropertyValues()
166167
.getPropertyValue("keyspaceNotificationsConfigParameter").getValue();
167168
}
168169

0 commit comments

Comments
 (0)