Add QUERY HTTP method
#33430
Add QUERY HTTP method
#33430
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the initial efforts @desiderantes - at this point the linked issue hasn't been triaged and is very unlikely to make it to the 6.2 version. We'll need thorough reviews and testing for this one. Note that since this is a new HTTP method and new feature, I don't think we will want to introduce it everywhere and for all variants of our web support. For example, I'm wondering if surfacing it as a first class citizen in |
bclozel
added
in: web
|
@bclozel Yes no worries, just wanted to get this started somehow. I do think that supporting a new HTTP Method shouldn't be half-hearted, and ideally it would mean support everywhere, not just in the basic |
|
@desiderantes We're trying to balance maintenance and evolution, especially around parts that have been very stable for a long time. Adding this method as first class in |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
bclozel
added
the
status: blocked
|
Marking as blocked for now because #32975 (comment) |
| } | ||
|
|
||
|
|
||
|
|
|
|
||
|
|
| boolean isQuery = HttpMethod.QUERY.matches(method); | ||
| if (isGet || isQuery || HttpMethod.HEAD.matches(method)) { |
There was a problem hiding this comment.
| boolean isQuery = HttpMethod.QUERY.matches(method); | |
| if (isGet || isQuery || HttpMethod.HEAD.matches(method)) { | |
| boolean isQuery = HttpMethod.QUERY.matches(method); | |
| boolean isHead = HttpMethod.HEAD.matches(method); | |
| if (isGet || isQuery || isHead) { |
align pattern
maybe then putting this PR into draft mode would help or communicate or even close as not planned. It can be reopened anytime |
| MockHttpServletRequest request = new MockHttpServletRequestBuilder(POST).uri("/foo") | ||
| .contentType(contentType).content(body.getBytes(UTF_8)) | ||
| .buildRequest(this.servletContext); | ||
| for (HttpMethod method : List.of(POST, QUERY)) { |
There was a problem hiding this comment.
Could it be better to use parametrized tests?
Fixes #32975