Ensure that ConversionService.canConvert(Enum) no longer throws an exception #34532
+41
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I use the following code to find an appropriate method to execute for a given class. It throws an
IllegalArgumentException: The target type java.lang.Enum does not refer to an enum
when there is a more appropriate “method”:asString(CharSequence)
.After doing some research I realized that the root cause was that
StringToEnumConverterFactory.getConverter(Enum.class)
threw an exception when it couldn't convert and resolve the concreteEnum
. This directly causesConversionService.canConvert(String.class,Enum.class)
to throw an exception. I don't think the methodcanConvert()
should throw an exception, it returnstrue
if it can convert andfalse
if it can't. That's what this method is for, to avoid throwing an exception when calling theconvert
method directly.So I've modified
StringToEnumConverterFactory
andIntegerToEnumConverterFactory
a little and hopefully this PR will be accepted.