Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Support for the new architecture #159

Merged
merged 14 commits into from
Mar 27, 2025
Merged

[Feat] Support for the new architecture #159

merged 14 commits into from
Mar 27, 2025

Conversation

Joaguirrem
Copy link
Collaborator

🔄 Type of change:

  • ✨Feature/chore
  • ♻️ Refactor
  • 🔧 Bugfixes

✏️ Description:

  • Add support for the new architecture.
  • Update dependencies.
  • Update ESLint config.

@Joaguirrem Joaguirrem marked this pull request as ready for review March 26, 2025 21:47
Copy link
Contributor

@carozo carozo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job! 🚀 🥳

Copy link
Collaborator

@mirland mirland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mirland mirland requested a review from Copilot March 27, 2025 13:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for the new architecture while updating dependencies and ESLint configurations to align with the enhanced API usage.

  • Update the login function to pass an empty object parameter.
  • Refactor imports and error handling in TypeScript files.
  • Modify ESLint config to use a new TypeScript ESLint import and remove legacy files.

Reviewed Changes

Copilot reviewed 20 out of 33 changed files in this pull request and generated no comments.

Show a summary per file
File Description
example/app/(app)/login.tsx Update login call to use an empty object parameter.
example/app/(app)/home.tsx Change import style and update error type for clearer error handling.
eslint.config.mjs Switch ESLint configuration to import a TypeScript ESLint module differently.
android/src/main/java/com/xmartlabs/rnline/RNLinePackage.java Remove unused native package code in preparation for the new architecture.
RNLine.podspec Remove the podspec file no longer needed with the updated architecture.
README.md Update documentation including Swift/Objective-C headers and code usage examples.
Files not reviewed (13)
  • android/build.gradle: Language not supported
  • android/src/main/AndroidManifest.xml: Language not supported
  • android/src/main/java/com/xmartlabs/line/LineLoginModule.kt: Language not supported
  • android/src/main/java/com/xmartlabs/line/LineLoginPackage.kt: Language not supported
  • android/src/main/res/values/strings.xml: Language not supported
  • example/app.json: Language not supported
  • example/package.json: Language not supported
  • ios/LineLogin.h: Language not supported
  • ios/LineLogin.m: Language not supported
  • ios/LineLogin.swift: Language not supported
  • ios/LineLoginModule-Bridging-Header.h: Language not supported
  • ios/LineLoginModule.mm: Language not supported
  • ios/LineLoginModule.swift: Language not supported
Comments suppressed due to low confidence (2)

example/app/(app)/home.tsx:18

  • Changing the error type from 'any' to 'Error' may introduce issues if non-Error objects are thrown. Verify that all error instances conform to the Error interface or consider using an 'unknown' type with proper type guards.
function handleError(error: Error) {

eslint.config.mjs:4

  • Ensure that the imported 'typescript-eslint' package provides a 'configs.recommended' export as used on line 29. If not, consider importing from '@typescript-eslint/eslint-plugin' or adjusting the usage accordingly.
import tseslint from 'typescript-eslint'

@mirland
Copy link
Collaborator

mirland commented Mar 27, 2025

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

CodiumAI-Agent commented Mar 27, 2025

PR Reviewer Guide 🔍

(Review updated until commit c7451aa)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 5 🔵🔵🔵🔵🔵
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Undefined Variable

The newly added handleError function uses strings.errorTitle and strings.errorMessage without a clear definition or import of strings. Please ensure that strings is defined or imported so that error handling works as expected.

function handleError(error: Error) {
  return Alert.alert(strings.errorTitle, error?.message ?? strings.errorMessage)
}

@Joaguirrem Joaguirrem merged commit 36f693b into main Mar 27, 2025
1 check passed
@CodiumAI-Agent
Copy link

Persistent review updated to latest commit c7451aa

@Joaguirrem Joaguirrem deleted the new-arch branch March 27, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants