-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pscan rule handling #481
Conversation
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the handling of passive scan rules to align with changes needed for ZAP 2.16.0 and later, including updates to extension names and API calls.
- Updated the extension retrieval in scan_rule_list.js from the ZAP extension to the addon version.
- Replaced plugin retrieval APIs with new passive scanner manager methods in both scan_rule_list.js and alertAndPluginDetails.js.
- Updated the CHANGELOG to reflect these changes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
standalone/scan_rule_list.js | Updated extension and scanner retrieval to use the new API calls. |
standalone/alertAndPluginDetails.js | Replaced legacy plugin access with the new passive scanner manager methods. |
CHANGELOG.md | Documented the changes for compatibility with ZAP 2.16.0+. |
Comments suppressed due to low confidence (2)
standalone/scan_rule_list.js:34
- Ensure that the getPassiveScannersManager().getScanRules() method returns an array or iterable that is compatible with the subsequent loop structure, since the previous implementation explicitly used toArray().
plugins = extPscan.getPassiveScannersManager().getScanRules();
standalone/alertAndPluginDetails.js:46
- Verify that getScanRule(alert.getPluginId()) returns a plugin object compatible with the rest of the code (e.g., providing a getName() method) to ensure consistent functionality with the previous API call.
plugin = extPscan.getPassiveScannersManager().getScanRule(alert.getPluginId());
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
Thank you! |
No description provided.