Dashboard v2: Implement PHP version settings #103668

fushar · 2025-05-23T12:53:18Z

Proposed Changes

This PR implements Settings -> PHP as follows.

Simple sites

In simple sites, we don't know the PHP version, and we don't advertise it. See discussion: p1747972441625309-slack-C08JZTRS6NA

The upsell will be handled separately as DOTCOM-13292.

Atomic sites

We show a warning badge if the version is not the recommended one.

While working on it, I found that the "Select item" placeholder option in the <select> is still selectable... filed DOTCOM-13298.

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

matticbot · 2025-05-23T12:53:22Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-145608

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-145608&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-145608&env=a8c-for-agencies

matticbot · 2025-05-23T13:00:21Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

help-center
notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug settings-php on your sandbox.

matticbot · 2025-05-23T13:02:32Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~257 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
entry-dashboard-dotcom      +2588 B  (+0.2%)     +311 B  (+0.1%)
entry-dashboard-a4a         +2588 B  (+0.2%)     +311 B  (+0.1%)
entry-subscriptions          +357 B  (+0.0%)      +94 B  (+0.0%)
entry-stepper                +357 B  (+0.0%)      +93 B  (+0.0%)
entry-reauth-required        +357 B  (+0.0%)      +94 B  (+0.0%)
entry-main                   +357 B  (+0.0%)      +90 B  (+0.0%)
entry-domains-landing        +357 B  (+0.1%)      +94 B  (+0.0%)
entry-browsehappy            +357 B  (+0.2%)      +94 B  (+0.2%)
entry-login                  +227 B  (+0.0%)      +45 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~18 bytes removed 📉 [gzipped])

name                          parsed_size           gzip_size
staging-site                       -141 B  (-0.0%)      -31 B  (-0.0%)
async-step-unified-plans           -141 B  (-0.0%)      -13 B  (-0.0%)
a8c-for-agencies-sites             -141 B  (-0.0%)       -9 B  (-0.0%)
a8c-for-agencies-overview          -141 B  (-0.0%)       -9 B  (-0.0%)
a8c-for-agencies-migrations        -141 B  (-0.0%)       -9 B  (-0.0%)
a8c-for-agencies-marketplace       -141 B  (-0.0%)       -9 B  (-0.0%)
site-settings                      +107 B  (+0.0%)      +10 B  (+0.0%)
hosting                            +107 B  (+0.0%)       +3 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

taipeicoder

Needs rebasing, but otherwise looks good to me.

StevenDufresne · 2025-05-25T22:25:53Z

~~Should we make sure users can't submit the "Select item" option?~~

Nevermind, missed the issue linked in description.

StevenDufresne · 2025-05-25T22:34:07Z

client/dashboard/sites/settings-php/index.tsx

+		fields: [ 'version' ],
+	};
+
+	const isDirty = formData.version !== version;


Nit: Would it make sense to name version to currentVersion for better readability, and in case formData.version is deconstructed?

Good idea, done!

ellatrix · 2025-05-26T07:49:05Z

client/dashboard/app/router.tsx

+	loader: async ( { params: { siteSlug } } ) => {
+		const site = await queryClient.ensureQueryData( siteQuery( siteSlug ) );
+		if ( canUpdatePHPVersion( site ) ) {
+			return await queryClient.ensureQueryData( sitePHPVersionQuery( siteSlug ) );


Nit: no need to return anything

Addressing it in #103702

ellatrix · 2025-05-26T07:51:45Z

client/dashboard/sites/settings-php/index.tsx

+		} );
+	};
+
+	const renderForm = () => {


Why is this an inline function? I've always found these weird. Why not render it in canUpdate ? ... : ...? Or make a new component if it needs to be reusable?

I think it's just a matter of taste; I just find it's easier to read / follow instead of a giant ternary :)

Maybe @taipeicoder can update it when you implement the upsell 🙈

It's fine, I just don't often see it I guess :)

Addressing it in #103702

fushar marked this pull request as ready for review May 23, 2025 15:03

fushar requested review from a team and youknowriad as code owners May 23, 2025 15:03

matticbot added the [Status] Needs Review label May 23, 2025

fushar self-assigned this May 23, 2025

fushar added the [Feature] Multi-site Dashboard label May 23, 2025

taipeicoder approved these changes May 25, 2025

View reviewed changes

StevenDufresne reviewed May 25, 2025

View reviewed changes

StevenDufresne mentioned this pull request May 25, 2025

Hosting Dashboard: Implement Handling requests for nonexistent assets setting screen #103694

Merged

8 tasks

Dashboard v2: Implement PHP version settings

482b6d2

fushar force-pushed the settings-php branch from 8d8f304 to c654d1a Compare May 26, 2025 01:34

version -> currentVersion

43201ac

fushar force-pushed the settings-php branch from c654d1a to 43201ac Compare May 26, 2025 01:35

fushar merged commit 0a06305 into trunk May 26, 2025
11 checks passed

fushar deleted the settings-php branch May 26, 2025 03:26

github-actions bot removed the [Status] Needs Review label May 26, 2025

ellatrix reviewed May 26, 2025

View reviewed changes

gabrielcaires pushed a commit that referenced this pull request May 26, 2025

Dashboard v2: Implement PHP version settings (#103668)

b75094c

fushar mentioned this pull request May 26, 2025

Hosting Dashboard: Implement SettingsCallout component #103702

Merged

8 tasks

Dashboard v2: Implement PHP version settings #103668

Dashboard v2: Implement PHP version settings #103668

Uh oh!

Conversation

fushar commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Simple sites

Atomic sites

Pre-merge Checklist

Uh oh!

matticbot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matticbot commented May 23, 2025

Uh oh!

matticbot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taipeicoder left a comment

Choose a reason for hiding this comment

Uh oh!

StevenDufresne commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fushar commented May 23, 2025 •

edited

Loading

matticbot commented May 23, 2025 •

edited

Loading

matticbot commented May 23, 2025 •

edited

Loading

StevenDufresne commented May 25, 2025 •

edited

Loading